Skip to content

Commit cef1dbf

Browse files
committed
test
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
1 parent 4c21c9b commit cef1dbf

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

integration/raft/cft_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,8 @@ var _ = Describe("EndToEnd Crash Fault Tolerance", func() {
346346
Expect(err).NotTo(HaveOccurred())
347347

348348
By("Adding new ordering service node")
349-
time.Sleep(5 * time.Second)
349+
// time.Sleep(5 * time.Second)
350+
Eventually(network.OrdererRunner(orderers[0]).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
350351
addConsenter(network, peer, orderers[0], "testchannel", &etcdraft.Consenter{
351352
ServerTlsCert: ordererCert,
352353
ClientTlsCert: ordererCert,
@@ -840,7 +841,8 @@ var _ = Describe("EndToEnd Crash Fault Tolerance", func() {
840841
Expect(err).NotTo(HaveOccurred())
841842

842843
By("updating the config for " + o.Name)
843-
time.Sleep(5 * time.Second)
844+
// time.Sleep(5 * time.Second)
845+
Eventually(network.OrdererRunner(o).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
844846
updateOrdererConfig(network, o, nwo.ClusterPort, "testchannel", timeShift, c.OriginalConfig(), c.UpdatedConfig(), peer, o)
845847
}
846848

integration/raft/config_test.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -613,13 +613,15 @@ var _ = Describe("EndToEnd reconfiguration and onboarding", func() {
613613
}
614614

615615
By(fmt.Sprintf("Rotating cert on leader %d", leader))
616-
time.Sleep(5 * time.Second)
616+
// time.Sleep(5 * time.Second)
617+
Eventually(network.OrdererRunner(network.Orderers[leaderIndex]).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
617618
rotate(leaderIndex)
618619

619620
By("Rotating certificates of other orderer nodes")
620621
for i := range certificateRotations {
621622
if i != leaderIndex {
622-
time.Sleep(5 * time.Second)
623+
// time.Sleep(5 * time.Second)
624+
Eventually(network.OrdererRunner(network.Orderers[i]).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
623625
rotate(i)
624626
}
625627
}
@@ -705,7 +707,8 @@ var _ = Describe("EndToEnd reconfiguration and onboarding", func() {
705707
port := network.OrdererPort(o, nwo.ClusterPort)
706708

707709
By(fmt.Sprintf("Adding the future certificate of orderer node %d", i))
708-
time.Sleep(5 * time.Second)
710+
// time.Sleep(5 * time.Second)
711+
Eventually(network.OrdererRunner(o).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
709712
for _, channelName := range []string{"testchannel"} {
710713
addConsenter(network, peer, o, channelName, &etcdraft.Consenter{
711714
ServerTlsCert: rotation.newCert,
@@ -732,8 +735,9 @@ var _ = Describe("EndToEnd reconfiguration and onboarding", func() {
732735
assertBlockReception(expectedBlockNumPerChannel[i*2], orderers, peer, network)
733736

734737
By("Removing the previous certificate of the old orderer")
735-
time.Sleep(5 * time.Second)
738+
// time.Sleep(5 * time.Second)
736739
for _, channelName := range []string{"testchannel"} {
740+
Eventually(network.OrdererRunner(o).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
737741
removeConsenter(network, peer, network.Orderers[(i+1)%len(network.Orderers)], channelName, rotation.oldCert)
738742
}
739743

@@ -1154,7 +1158,8 @@ var _ = Describe("EndToEnd reconfiguration and onboarding", func() {
11541158
Expect(err).To(Not(HaveOccurred()))
11551159

11561160
ordererEvicted1st := network.Orderers[(firstEvictedNode+1)%3]
1157-
time.Sleep(5 * time.Second)
1161+
// time.Sleep(5 * time.Second)
1162+
Eventually(network.OrdererRunner(ordererEvicted1st).Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("store active nodes - "))
11581163
removeConsenter(network, peer, ordererEvicted1st, "testchannel", server1CertBytes)
11591164

11601165
var survivedOrdererRunners []*ginkgomon.Runner

orderer/consensus/etcdraft/chain.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,6 +535,7 @@ func (c *Chain) Consensus(req *orderer.ConsensusRequest, sender uint64) error {
535535

536536
c.Metrics.ActiveNodes.Set(float64(len(clusterMetadata.ActiveNodes)))
537537
c.ActiveNodes.Store(clusterMetadata.ActiveNodes)
538+
c.logger.Debugf("store active nodes - %d", len(clusterMetadata.ActiveNodes))
538539

539540
return nil
540541
}

0 commit comments

Comments
 (0)