Skip to content

Commit aea4417

Browse files
committed
WIP: use WidgetStyle utility class to correctly determine styles
TODO: - fix SwingFileWidget.createFileFilter - add tests
1 parent 08fb795 commit aea4417

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

pom.xml

+2-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.scijava</groupId>
77
<artifactId>pom-scijava</artifactId>
8-
<version>28.0.0</version>
8+
<version>29.2.1</version>
99
<relativePath />
1010
</parent>
1111

@@ -108,8 +108,7 @@
108108
<jdatepicker.version>1.3.2</jdatepicker.version>
109109
<object-inspector.version>0.1</object-inspector.version>
110110

111-
<miglayout-swing.version>5.2</miglayout-swing.version>
112-
<scijava-ui-awt.version>0.1.7</scijava-ui-awt.version>
111+
<scijava-common.version>2.85.0</scijava-common.version>
113112
</properties>
114113

115114
<repositories>

src/main/java/org/scijava/ui/swing/AbstractSwingUI.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
import org.scijava.ui.viewer.DisplayViewer;
7070
import org.scijava.widget.FileListWidget;
7171
import org.scijava.widget.FileWidget;
72+
import org.scijava.widget.WidgetStyle;
7273

7374
/**
7475
* Abstract superclass for Swing-based user interfaces.
@@ -141,11 +142,11 @@ public File chooseFile(final File file, final String style) {
141142
// be a deadlock, particularly on macOS. See scijava/scijava-ui-swing#28.
142143
threadService.invoke(() -> {
143144
final JFileChooser chooser = new JFileChooser(file);
144-
if (FileWidget.DIRECTORY_STYLE.equals(style)) {
145+
if (WidgetStyle.isStyle(style, FileWidget.DIRECTORY_STYLE)) {
145146
chooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
146147
}
147148
final int rval;
148-
if (FileWidget.SAVE_STYLE.equals(style)) {
149+
if (WidgetStyle.isStyle(style, FileWidget.SAVE_STYLE)) {
149150
rval = chooser.showSaveDialog(appFrame);
150151
}
151152
else { // default behavior
@@ -172,10 +173,10 @@ public File[] chooseFiles(final File parent, final File[] files, final FileFilte
172173
threadService.invoke(() -> {
173174
final JFileChooser chooser = new JFileChooser(parent);
174175
chooser.setMultiSelectionEnabled(true);
175-
if (style.equals(FileListWidget.FILES_AND_DIRECTORIES)) {
176+
if (WidgetStyle.isStyle(style, FileListWidget.FILES_AND_DIRECTORIES)) {
176177
chooser.setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);
177178
}
178-
else if (style.equals(FileListWidget.DIRECTORIES_ONLY)) {
179+
else if (WidgetStyle.isStyle(style, FileListWidget.DIRECTORIES_ONLY)) {
179180
chooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
180181
}
181182
else {

src/main/java/org/scijava/ui/swing/widget/SwingFileListWidget.java

-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
import org.scijava.plugin.Parameter;
6666
import org.scijava.plugin.Plugin;
6767
import org.scijava.thread.ThreadService;
68-
import org.scijava.ui.UIService;
6968
import org.scijava.widget.FileListWidget;
7069
import org.scijava.widget.FileWidget;
7170
import org.scijava.widget.InputWidget;

0 commit comments

Comments
 (0)