Skip to content

Commit 5eb7145

Browse files
chore: use pip instead of docker for clang-format (#610)
* chore: use conda instead of docker for clang-format * Update .pre-commit-config.yaml * Update .pre-commit-config.yaml * Update .pre-commit-config.yaml * ci: use pre-commit * Update .pre-commit-config.yaml * Update .pre-commit-config.yaml * Use WIP clang 10 * style: pre-commit fixes * Update .pre-commit-config.yaml * style: pre-commit fixes Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 4032770 commit 5eb7145

File tree

3 files changed

+7
-26
lines changed

3 files changed

+7
-26
lines changed

.github/workflows/tests.yml

-12
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,6 @@ on:
99
- develop
1010

1111
jobs:
12-
pre-commit:
13-
name: Format
14-
runs-on: ubuntu-latest
15-
steps:
16-
- uses: actions/checkout@v1
17-
with:
18-
submodules: true
19-
- uses: actions/setup-python@v2
20-
- uses: pre-commit/[email protected]
21-
with:
22-
extra_args: -a docker-clang-format --hook-stage manual
23-
2412
clang-tidy:
2513
name: Clang-Tidy
2614
runs-on: ubuntu-latest

.pre-commit-config.yaml

+5-12
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ci:
2-
skip:
3-
- docker-clang-format
2+
autoupdate_commit_msg: "chore: update pre-commit hooks"
3+
autofix_commit_msg: "style: pre-commit fixes"
44

55
repos:
66
- repo: https://github.com/psf/black
@@ -81,14 +81,7 @@ repos:
8181
entry: PyBind|Numpy|Cmake|CCache|Github|PyTest
8282
exclude: .pre-commit-config.yaml
8383

84-
- repo: local
84+
- repo: https://github.com/ssciwr/clang-format-precommit
85+
rev: v12.0.1
8586
hooks:
86-
- id: docker-clang-format
87-
name: Docker Clang Format
88-
language: docker_image
89-
types:
90-
- c++
91-
entry: unibeautify/clang-format:latest
92-
args:
93-
- -style=file
94-
- -i
87+
- id: clang-format

include/bh_python/make_pickle.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
#include <vector>
6161

6262
template <class T,
63-
class = decltype(
64-
std::declval<T&>().serialize(std::declval<std::nullptr_t&>(), 0))>
63+
class = decltype(std::declval<T&>().serialize(std::declval<std::nullptr_t&>(),
64+
0))>
6565
struct has_method_serialize_impl {};
6666

6767
template <class T>

0 commit comments

Comments
 (0)