extended testing of pickling (#589)

Author: HDembinski

.github/workflows/wheels.yml

@@ -4,17 +4,9 @@ on:
   push:
     branches:
     - beta-*
-    paths-ignore:
-      - 'doc/**'
-      - '.ci/**'
-      - '*.rst'
   pull_request:
     branches:
     - master
-    paths-ignore:
-      - 'doc/**'
-      - '.ci/**'
-      - '*.rst'
   release:
     types: [published]
 

doc/changelog.rst

@@ -10,6 +10,7 @@ Changelog
 
 New features
 ~~~~~~~~~~~~
+- Minuit object is now pickle-able and copy-able
 - More efficient internal conversion between Python objects and ``std::vector<double>``
 
 Bug-fixes
@@ -19,7 +20,7 @@ Bug-fixes
 
 Other
 ~~~~~
-- Unit tests are now included again in sdist package
+- Unit tests are included again in sdist package
 - ``Minuit.grad`` now returns ``numpy.ndarray`` instead of a ``list``
 - Fixes for ``conda`` builds on Windows platform with ``msvc``, by @henryiii
 - Updated and unified documentation on how to cite iminuit

src/iminuit/_minuit.py

@@ -486,7 +486,7 @@ def fcn_np(x):
         self._values = mutil.ValueView(self)
         self._errors = mutil.ErrorView(self)
         self._fixed = mutil.FixedView(self)
-        self._limits = mutil.LimitView(self, 1)
+        self._limits = mutil.LimitView(self)
 
         self.precision = getattr(fcn, "precision", None)
 

src/iminuit/util.py

@@ -120,6 +120,9 @@ def _set(self, i, fix):
 class LimitView(BasicView):
     """Array-like view of parameter limits."""
 
+    def __init__(self, minuit):
+        super(LimitView, self).__init__(minuit, 1)
+
     def _get(self, i):
         p = self._minuit._last_state[i]
         return (

tests/test_minuit.py

@@ -1408,24 +1408,40 @@ def test_repr():
 def test_pickle(grad):
     import pickle
 
-    m = Minuit(func0, x=0, y=0, grad=grad)
+    m = Minuit(func0, x=1, y=1, grad=grad)
+    m.fixed[1] = True
+    m.limits[0] = 0, 10
     m.migrad()
-    m.minos()
 
     pkl = pickle.dumps(m)
     m2 = pickle.loads(pkl)
 
-    assert m2.fmin == m.fmin
+    assert id(m2) != id(m)
+    # check correct linking of views
+    assert id(m2.values._minuit) == id(m2)
+    assert id(m2.errors._minuit) == id(m2)
+    assert id(m2.limits._minuit) == id(m2)
+    assert id(m2.fixed._minuit) == id(m2)
+
+    assert m2.init_params == m.init_params
     assert m2.params == m.params
-    assert m2.merrors == m.merrors
+    assert m2.fmin == m.fmin
     assert_equal(m2.covariance, m.covariance)
 
+    m.fixed = False
+    m2.fixed = False
+    m.migrad()
+    m.minos()
+
     m2.migrad()
-    m2.hesse()
     m2.minos()
 
-    assert m2.fmin.edm < m.fmin.edm
-    assert m2.fmin.nfcn > m.fmin.nfcn
+    assert m2.merrors == m.merrors
+
+    assert m2.fmin.fval == m.fmin.fval
+    assert m2.fmin.edm == m.fmin.edm
+    assert m2.fmin.nfcn == m.fmin.nfcn
+    assert m2.fmin.ngrad == m.fmin.ngrad
 
 
 def test_minos_new_min():