[WIP] Add Freesurfer container #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVCaron
requested changes
Apr 24, 2024
Collaborator
AlexVCaron
left a comment
AlexVCaron
left a comment
There was a problem hiding this comment.
Pretty much everything is there ! Once the comments are fixed, it should be good. You don't need scilpy from what I see ?
AlexVCaron
reviewed
Jun 2, 2024
| FROM freesurfer-base as freesurfer | ||
|
|
||
| ARG FREESURFER_VERSION | ||
| ENV FREESURFER_VERSION=${FREESURFER_VERSION:-${FREESURFER_VERSION}} |
Collaborator
There was a problem hiding this comment.
Revert this. The latter part sets the default if (1) ARG is not defined or (2) then variable is not defined in env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.