Skip to content

Conversation

@gdevenyi
Copy link
Collaborator

@gdevenyi gdevenyi commented Nov 26, 2025

Add into the CoBrALab custom ants registraiton script, in preparation for another registration module in nf-neuro

@gdevenyi
Copy link
Collaborator Author

@AlexVCaron I'm not sure where I should add ANTS_AFFINE_SYN_REVISION in this repo, can you assist?

@AlexVCaron
Copy link
Collaborator

Hi @gdevenyi, thanks for the PR, hope this help you !

Variables for versioning and the likes are defined on 3 levels, from top to bottom :

  1. docker-bake.override.hcl : final affectation of bake variables overwriting definitions in other bake files.
  2. docker-bake.hcl :
    • Top of the file : definition and default affectation of bake variables. ANTs ones are here.
    • Inside target definitions : affectation of bake variables to Dockerfile ARG in the args section. For ANTs, it's this one
  3. Dockerfile : definition with the ARG instruction, and default value using the ENV instruction. There you'll need to add the ARG, but the ENV is already setup correctly !

@gdevenyi gdevenyi force-pushed the add-antsRegistration_affine_SyN branch from f691076 to 09f6aa6 Compare November 26, 2025 16:48
@gdevenyi gdevenyi marked this pull request as ready for review November 26, 2025 16:49
@gdevenyi gdevenyi force-pushed the add-antsRegistration_affine_SyN branch from 09f6aa6 to 64f53fb Compare November 26, 2025 17:54
@AlexVCaron
Copy link
Collaborator

Sorry for the wait. The build passed, I verified the script availability. scilus/scilus:2.2.1 is live on DockerHub. I let you test it more extensively !

@gdevenyi
Copy link
Collaborator Author

gdevenyi commented Nov 27, 2025

Sorry for the wait. The build passed, I verified the script availability. scilus/scilus:2.2.1 is live on DockerHub. I let you test it more extensively !

Thanks! you move quickly ;)

Basing a registration module on the ants one right now that will use this. Expect a PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants