Skip to content

Conversation

@arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Aug 7, 2024

Quick description

First MRDS script - use MRDS output and NUFO like image and select the expected solutions.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

data

Command line:

scil_mrds_select_number_of_tensors.py sub-01 nufo.nii.gz 

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Aug 7, 2024

Hello @arnaudbore, Thank you for updating !

Line 20:80: E501 line too long (82 > 79 characters)
Line 74:80: E501 line too long (84 > 79 characters)
Line 77:80: E501 line too long (80 > 79 characters)
Line 80:80: E501 line too long (88 > 79 characters)
Line 89:80: E501 line too long (94 > 79 characters)
Line 97:80: E501 line too long (86 > 79 characters)
Line 100:80: E501 line too long (82 > 79 characters)

Comment last updated at 2024-11-13 20:12:15 UTC

@arnaudbore arnaudbore requested a review from mdesco August 7, 2024 21:16
@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.03%. Comparing base (8339116) to head (5a6a2bd).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   68.94%   69.03%   +0.09%     
==========================================
  Files         434      435       +1     
  Lines       22657    22728      +71     
  Branches     3080     3086       +6     
==========================================
+ Hits        15621    15691      +70     
  Misses       5724     5724              
- Partials     1312     1313       +1     
Components Coverage Δ
Scripts 69.83% <98.59%> (+0.15%) ⬆️
Library 67.91% <ø> (ø)

@arnaudbore arnaudbore mentioned this pull request Aug 7, 2024
13 tasks
@arnaudbore arnaudbore merged commit 2c2b4f6 into scilus:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants