-
Notifications
You must be signed in to change notification settings - Fork 71
[ENH] Add mrds scripts part 2 #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 68.94% 68.99% +0.05%
==========================================
Files 434 435 +1
Lines 22657 22713 +56
Branches 3080 3086 +6
==========================================
+ Hits 15621 15671 +50
- Misses 5724 5725 +1
- Partials 1312 1317 +5
|
|
Hello @arnaudbore, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-13 20:35:35 UTC |
scripts/scil_mrds_metrics.py
Outdated
| # -*- coding: utf-8 -*- | ||
|
|
||
| """ | ||
| Script to compute all of the Multi-Resolution Discrete-Search (MRDS) metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metrics -> multi-tensor metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I have seen the code, I'm not sure what this script does... single-tensor metrics only?
scripts/scil_mrds_metrics.py
Outdated
| g.add_argument('--rd', dest='rd', metavar='file', default='', | ||
| help='Output filename for the MRDS RD diffusivity.') | ||
| g.add_argument('--md', dest='md', metavar='file', default='', | ||
| help='Output filename for the MRDS MD diffusivity.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this script do? Compute the MRDS DTI metrics only? i.e. single-tensor metrics or it computes the tensor metrics for each tensor in the MRDS solution?
I'm confused...
Quick description
Script to compute FA, AD, MD, RD for each tensor found for MRDS
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
Same as #1021
Checklist