Skip to content

Conversation

@arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Aug 7, 2024

Quick description

Script to compute FA, AD, MD, RD for each tensor found for MRDS
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Same as #1021

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore requested a review from mdesco August 7, 2024 22:47
@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (8339116) to head (64303c7).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
+ Coverage   68.94%   68.99%   +0.05%     
==========================================
  Files         434      435       +1     
  Lines       22657    22713      +56     
  Branches     3080     3086       +6     
==========================================
+ Hits        15621    15671      +50     
- Misses       5724     5725       +1     
- Partials     1312     1317       +5     
Components Coverage Δ
Scripts 69.76% <92.85%> (+0.08%) ⬆️
Library 67.91% <ø> (ø)

@pep8speaks
Copy link

pep8speaks commented Nov 4, 2024

Hello @arnaudbore, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-13 20:35:35 UTC

# -*- coding: utf-8 -*-

"""
Script to compute all of the Multi-Resolution Discrete-Search (MRDS) metrics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics -> multi-tensor metrics

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I have seen the code, I'm not sure what this script does... single-tensor metrics only?

g.add_argument('--rd', dest='rd', metavar='file', default='',
help='Output filename for the MRDS RD diffusivity.')
g.add_argument('--md', dest='md', metavar='file', default='',
help='Output filename for the MRDS MD diffusivity.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this script do? Compute the MRDS DTI metrics only? i.e. single-tensor metrics or it computes the tensor metrics for each tensor in the MRDS solution?

I'm confused...

@arnaudbore arnaudbore merged commit 48d606d into scilus:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants