Skip to content

Conversation

@EmmaRenauld
Copy link
Contributor

A few unit tests

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.46%. Comparing base (7be3235) to head (c70592f).
⚠️ Report is 26 commits behind head on master.

❌ Your project status has failed because the head coverage (72.46%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   72.45%   72.46%   +0.01%     
==========================================
  Files         293      293              
  Lines       25194    25194              
  Branches     3527     3527              
==========================================
+ Hits        18254    18257       +3     
+ Misses       5448     5446       -2     
+ Partials     1492     1491       -1     
Flag Coverage Δ
smoketests 69.63% <100.00%> (+<0.01%) ⬆️
unittests 13.31% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.29% <ø> (+0.01%) ⬆️
Library 69.10% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arnaudbore
arnaudbore previously approved these changes Oct 31, 2025
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick fix otherwise LGTM

Co-authored-by: Arnaud Bore <[email protected]>
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore enabled auto-merge October 31, 2025 00:45
@arnaudbore arnaudbore added this pull request to the merge queue Oct 31, 2025
Merged via the queue into scilus:master with commit df80acf Oct 31, 2025
3 checks passed
@EmmaRenauld EmmaRenauld deleted the unit_bundles branch October 31, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants