Skip to content

Conversation

@EmmaRenauld
Copy link
Contributor

Fixes issues #1241 and #1267

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore enabled auto-merge October 31, 2025 12:55
@arnaudbore arnaudbore added this pull request to the merge queue Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.44%. Comparing base (df80acf) to head (c08651b).
⚠️ Report is 3 commits behind head on master.

❌ Your project status has failed because the head coverage (72.44%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   72.45%   72.44%   -0.02%     
==========================================
  Files         293      293              
  Lines       25203    25203              
  Branches     3530     3530              
==========================================
- Hits        18262    18259       -3     
  Misses       5450     5450              
- Partials     1491     1494       +3     
Flag Coverage Δ
smoketests 69.62% <ø> (-0.01%) ⬇️
unittests 13.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.28% <ø> (-0.01%) ⬇️
Library 69.08% <ø> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into scilus:master with commit 33c01d9 Oct 31, 2025
3 checks passed
@EmmaRenauld EmmaRenauld deleted the fix_links branch October 31, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants