Adding option in custom-color for coverage #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudbore
previously approved these changes
Oct 31, 2025
Contributor
arnaudbore
left a comment
arnaudbore
left a comment
There was a problem hiding this comment.
quick typo and then merge
Comment on lines
122
to
123
| '[%(default)s].\nYou may also two Matplotlib named colors ' | ||
| 'separeted by a - to create your own colormap. ' |
Contributor
There was a problem hiding this comment.
missing something in the sentence
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (72.55%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
+ Coverage 72.45% 72.55% +0.09%
==========================================
Files 293 294 +1
Lines 25203 25305 +102
Branches 3530 3543 +13
==========================================
+ Hits 18262 18360 +98
Misses 5450 5450
- Partials 1491 1495 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arnaudbore
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to test custom-made colormap for more coverage.
This fixes issue #1152, which was not really an issue, just my bad understanding! Added clarifications in the doc.