Skip to content

Conversation

@frheault
Copy link
Member

@frheault frheault commented Nov 6, 2025

Quick description

We get the error

  File "src/scilpy/tractograms/uncompress.pyx", line 84, in scilpy.tractograms.uncompress.streamlines_to_voxel_coordinates
ValueError: Buffer dtype mismatch, expected 'float' but got 'double'

The only fix without editing cython is to cast as float32 and keep the previous behavior. We could also modify the cython code to expect double, but we typically avoid touching cython code at the moment... (especially anything in uncompress.pyx)

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.60%. Comparing base (095637c) to head (353dc6f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   72.58%   72.60%   +0.01%     
==========================================
  Files         294      294              
  Lines       25328    25332       +4     
  Branches     3546     3546              
==========================================
+ Hits        18385    18392       +7     
+ Misses       5448     5445       -3     
  Partials     1495     1495              
Flag Coverage Δ
smoketests 69.78% <100.00%> (+0.01%) ⬆️
unittests 13.30% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.45% <100.00%> (+0.01%) ⬆️
Library 69.20% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants