-
Notifications
You must be signed in to change notification settings - Fork 71
FIX: BundleParc -- min_blob_size and keep_biggest were not used #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the BundleParc script where the predict function was being called with incorrect parameters, causing min_blob_size and keep_biggest_blob arguments to be ignored. The fix ensures these user-specified parameters are now properly passed to the prediction function, allowing users to control blob filtering behavior.
Key Changes:
- Fixed the
predictfunction call to properly passargs.min_blob_sizeandargs.keep_biggest_blobas positional arguments - Added
--volume_sizeargument to allow users to control the resampling size (previously hardcoded to 128) - Reformatted the
predictfunction call for better readability with one parameter per line
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 72.59% 72.59% -0.01%
==========================================
Files 294 294
Lines 25339 25340 +1
Branches 3546 3546
==========================================
Hits 18395 18395
Misses 5448 5448
- Partials 1496 1497 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Quick description
See title. The
predictfunction was incorrectly called which put--min_blob_size=1and--keep_biggest_blob=Falseno matter the arguments.Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist