Skip to content

Commit e127b14

Browse files
Fix review findings
1 parent 4814822 commit e127b14

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/pyscipopt/scip.pxi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10205,7 +10205,7 @@ cdef class Model:
1020510205
1020610206
Returns
1020710207
-------
10208-
int
10208+
float
1020910209
node selection priority for moving the given variable's LP value to the given target value
1021010210
1021110211
"""
@@ -10238,7 +10238,7 @@ cdef class Model:
1023810238
1023910239
Parameters
1024010240
----------
10241-
nodeselprio : int
10241+
nodeselprio : float
1024210242
node selection priority of new node
1024310243
estimate : float
1024410244
estimate for (transformed) objective value of best feasible solution in subtree

src/pyscipopt/scip.pyi

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ class Model:
693693
) -> Constraint: ...
694694
def addConsLocal(
695695
self,
696-
cons: Constraint,
696+
cons: Incomplete,
697697
validnode: Node | None = None,
698698
name: str = "",
699699
initial: bool = True,
@@ -705,11 +705,11 @@ class Model:
705705
dynamic: bool = False,
706706
removable: bool = True,
707707
stickingatnode: bool = True,
708-
) -> None: ...
708+
) -> Constraint: ...
709709
def addConsNode(
710710
self,
711711
node: Node,
712-
cons: Constraint,
712+
cons: Incomplete,
713713
validnode: Node | None = None,
714714
name: str = "",
715715
initial: bool = True,
@@ -721,7 +721,7 @@ class Model:
721721
dynamic: bool = False,
722722
removable: bool = True,
723723
stickingatnode: bool = True,
724-
) -> None: ...
724+
) -> Constraint: ...
725725
def addConsOr(
726726
self,
727727
vars: Sequence[Variable],
@@ -913,7 +913,7 @@ class Model:
913913
def calcChildEstimate(self, variable: Variable, targetvalue: float) -> float: ...
914914
def calcNodeselPriority(
915915
self, variable: Variable, branchdir: Incomplete, targetvalue: float
916-
) -> int: ...
916+
) -> float: ...
917917
def catchEvent(self, eventtype: Incomplete, eventhdlr: Eventhdlr) -> None: ...
918918
def catchRowEvent(
919919
self, row: Row, eventtype: Incomplete, eventhdlr: Eventhdlr
@@ -964,7 +964,7 @@ class Model:
964964
self, to_fix: Sequence[Variable], fix_vals: Sequence[float]
965965
) -> Model: ...
966966
def count(self) -> None: ...
967-
def createChild(self, nodeselprio: int, estimate: float) -> Node: ...
967+
def createChild(self, nodeselprio: float, estimate: float) -> Node: ...
968968
def createCons(
969969
self,
970970
conshdlr: Conshdlr,
@@ -1125,7 +1125,7 @@ class Model:
11251125
def getLPRowsData(self) -> list[Row]: ...
11261126
def getLPSolstat(self) -> Incomplete: ...
11271127
def getLeaves(self) -> list[Node]: ...
1128-
def getLhs(self, cons: Constraint) -> None: ...
1128+
def getLhs(self, cons: Constraint) -> float: ...
11291129
def getLinearConsIndicator(self, cons: Constraint) -> Constraint | None: ...
11301130
def getLocalEstimate(self, original: bool = False) -> float: ...
11311131
def getLowerbound(self) -> float: ...
@@ -1490,7 +1490,7 @@ class Model:
14901490
def setBendersSubproblemIsConvex(
14911491
self, benders: Benders, probnumber: int, isconvex: bool = True
14921492
) -> None: ...
1493-
def setBoolParam(self, name: str, value: float) -> None: ...
1493+
def setBoolParam(self, name: str, value: bool) -> None: ...
14941494
def setCharParam(self, name: str, value: str) -> None: ...
14951495
def setCheck(self, cons: Constraint, newCheck: bool) -> None: ...
14961496
def setEmphasis(self, paraemphasis: Incomplete, quiet: bool = True) -> None: ...

0 commit comments

Comments
 (0)