Summary
The Integration test workflow currently runs after changes are pushed to master.
This means integration failures can be detected only after a pull request has already been merged. This happened in #1246, where a Windows-specific test failure was caught only after merge.
Proposed change
Run the integration tests as a pre-merge check, so that failures are detected before changes reach master.
The integration tests should run at merge time rather than on every push or update to a pull request.
Considerations
The workflow currently runs a relatively large test matrix across multiple Python versions and platforms, so avoiding unnecessary runs on every PR update is important.
The exact mechanism for triggering the integration tests at merge time can be determined as part of the implementation.
Related
Summary
The
Integration testworkflow currently runs after changes are pushed tomaster.This means integration failures can be detected only after a pull request has already been merged. This happened in #1246, where a Windows-specific test failure was caught only after merge.
Proposed change
Run the integration tests as a pre-merge check, so that failures are detected before changes reach
master.The integration tests should run at merge time rather than on every push or update to a pull request.
Considerations
The workflow currently runs a relatively large test matrix across multiple Python versions and platforms, so avoiding unnecessary runs on every PR update is important.
The exact mechanism for triggering the integration tests at merge time can be determined as part of the implementation.
Related