implement freemodel!

 - make sure that SCIP is not freed twice

Author: rschwarz

src/mpb_interface.jl

@@ -18,7 +18,10 @@ numvar(m::SCIPMathProgModel) = _getNumVars(m)
 "The number of proper constraints, excluding those from lazy callbacks."
 numconstr(m::SCIPMathProgModel) = _getNumConss(m)
 
-freemodel!(m::SCIPMathProgModel) = error("Not implemented for SCIP.jl!")
+function freemodel!(m::SCIPMathProgModel)
+    # call finalizer directly
+    freescip(m.inner)
+end
 
 # TODO: mapping for :SemiCont, :SemiInt
 const vartypemap = Dict{Symbol, Cint}(

src/types.jl

@@ -21,8 +21,13 @@ type SCIPModel
 end
 
 function freescip(m::SCIPModel)
-    @assert m.ptr_model != C_NULL
-    _freeModel(m)
+    # avoid double free
+    if m.ptr_model != C_NULL
+        _freeModel(m)
+        m.ptr_model = C_NULL
+    else
+        Base.warn_once("Tried to free already freed model, ignoring.")
+    end
 end
 
 # Linear Quadratic Model