Merge branch '3924-fix-scip-exact-mode-segfaults-double-free-on-exit-4' into 'master'

ambros-gleixner · ambros-gleixner · commit a05fc597d21c · 2025-05-27T08:17:37.000+02:00
Resolve "SCIP exact mode segfaults (double free?) on exit" infinity

See merge request integer/scip!3859
diff --git a/src/scip/cons_exactlinear.c b/src/scip/cons_exactlinear.c
@@ -2815,6 +2815,8 @@ void consdataGetActivity(
       }
       assert(nneginf >= 0 && nposinf >= 0);
 
+      SCIPrationalFreeBuffer(SCIPbuffer(scip), &solval);
+
       SCIPdebugMsg(scip, "activity of linear constraint: %.15g, %d positive infinity values, %d negative infinity values \n", SCIPrationalGetReal(activity), nposinf, nneginf);
 
       /* check for amount of infinity values and correct the activity */
@@ -2827,7 +2829,6 @@ void consdataGetActivity(
          SCIPrationalSetNegInfinity(activity);
 
       SCIPrationalDebugMessage("corrected activity of linear constraint: %q\n", activity);
-      SCIPrationalFreeBuffer(SCIPbuffer(scip), &solval);
    }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2815,6 +2815,8 @@ void consdataGetActivity(`
`2815`	`2815`	`}`
`2816`	`2816`	`assert(nneginf >= 0 && nposinf >= 0);`
`2817`	`2817`
	`2818`	`+ SCIPrationalFreeBuffer(SCIPbuffer(scip), &solval);`
	`2819`	`+`
`2818`	`2820`	`SCIPdebugMsg(scip, "activity of linear constraint: %.15g, %d positive infinity values, %d negative infinity values \n", SCIPrationalGetReal(activity), nposinf, nneginf);`
`2819`	`2821`
`2820`	`2822`	`/* check for amount of infinity values and correct the activity */`
`@@ -2827,7 +2829,6 @@ void consdataGetActivity(`
`2827`	`2829`	`SCIPrationalSetNegInfinity(activity);`
`2828`	`2830`
`2829`	`2831`	`SCIPrationalDebugMessage("corrected activity of linear constraint: %q\n", activity);`
`2830`		`- SCIPrationalFreeBuffer(SCIPbuffer(scip), &solval);`
`2831`	`2832`	`}`
`2832`	`2833`	`}`
`2833`	`2834`