-
Notifications
You must be signed in to change notification settings - Fork 42
Get rid of OpenShift 3 functions #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[test] |
Let's tests also container images which are not released yet by commit 6c43d3d [test] |
But this commit can be part of alone PR :( |
This needs to be tested on several container manually and reported here. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Remove variable OS_CLUSTER_STARTED_BY_TEST. It is not used at all https://github.com/search?q=org%3Asclorg%20CT_SKIP_UPLOAD_IMAGE&type=code Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
6c43d3d
to
edcb76f
Compare
rebased against master [test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick. Otherwise I think this LGTM.
This needs to be tested on several container manually and reported here.