Skip to content

Get rid of OpenShift 3 functions #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Get rid of OpenShift 3 functions #366

merged 3 commits into from
Mar 27, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Mar 20, 2024

This needs to be tested on several container manually and reported here.

@phracek
Copy link
Member Author

phracek commented Mar 21, 2024

[test]

@phracek
Copy link
Member Author

phracek commented Mar 21, 2024

Let's tests also container images which are not released yet by commit 6c43d3d

[test]

@phracek
Copy link
Member Author

phracek commented Mar 21, 2024

Let's tests also container images which are not released yet by commit 6c43d3d

[test]

But this commit can be part of alone PR :(

phracek added 3 commits March 21, 2024 15:18
This needs to be tested on several container manually
and reported here.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Remove variable OS_CLUSTER_STARTED_BY_TEST.
It is not used at all
https://github.com/search?q=org%3Asclorg%20CT_SKIP_UPLOAD_IMAGE&type=code

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek force-pushed the get_rid_of_ocp3_functions branch from 6c43d3d to edcb76f Compare March 21, 2024 14:18
@phracek
Copy link
Member Author

phracek commented Mar 21, 2024

rebased against master

[test]

Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick. Otherwise I think this LGTM.

@phracek phracek merged commit 1f774c8 into master Mar 27, 2024
27 of 28 checks passed
@phracek phracek deleted the get_rid_of_ocp3_functions branch March 27, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants