Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build Fedora and CentOS Stream images also for arm64 #660

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Mar 6, 2024

Depends on: sclorg/s2i-base-container#292
Resolves: #659

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But question. Why to not enable all archs like in postgresql-container

archs: amd64, s390x, ppc64le, arm64

I think the new request will come soon if we support part of architectures https://github.com/sclorg/postgresql-container/blob/master/.github/workflows/build-and-push.yml#L121

@zmiklank
Copy link
Contributor Author

zmiklank commented Mar 6, 2024

LGTM. But question. Why to not enable all archs like in postgresql-container

Sure, we can do that. I was going with minimal option, but I am OK also with enabling all the arch. If not for python, then at least for s2i base and core. Should I update the PR accordingly?

@pkubatrh
Copy link
Member

pkubatrh commented Mar 6, 2024

+1 to enabling all for s2i-core and s2i-base (since we already build all for postgresql anyway), I would keep only arm for python, as we didnt get any requests for other architectures yet.

@zmiklank
Copy link
Contributor Author

zmiklank commented Mar 6, 2024

Done for s2i-base and s2i-core:
sclorg/s2i-base-container#292

Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it and I'm fine with minimum approach here and all architectures for base and core.

@zmiklank zmiklank merged commit 3b69517 into sclorg:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish arm64 images
4 participants