-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store PIP_INDEX_URL value in pip.ini config when present during assemble #664
Conversation
[test-all] |
[test-all] |
test/run
Outdated
@@ -6,7 +6,7 @@ | |||
# IMAGE_NAME specifies a name of the candidate image used for testing. | |||
# The image has to be available before this script is executed. | |||
# | |||
declare -a COMMON_WEB_APPS=({gunicorn-config-different-port,gunicorn-different-port,django-different-port,standalone,setup,setup-requirements,django,numpy,app-home,locale,pipenv,pipenv-and-micropipenv-should-fail,app-module,pyuwsgi-pipenv{% if spec.version.startswith("3.") %},micropipenv{% endif %}}-test-app) | |||
declare -a COMMON_WEB_APPS=({gunicorn-config-different-port,gunicorn-different-port,django-different-port,standalone,standalone-custom-pypi-index-test-app,setup,setup-requirements,django,numpy,app-home,locale,pipenv,pipenv-and-micropipenv-should-fail,app-module,pyuwsgi-pipenv{% if spec.version.startswith("3.") %},micropipenv{% endif %}}-test-app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list uses a shell expansion so the name of the test should not contain -test-app
. See the rest of the tests in the list.
[test-all] |
[test-all] |
[test-all] |
[test-all] |
[test-all] |
[test] |
[test-all] |
[test-all] |
RHEL8 - Python 2.7 failure:
|
[test] |
The PR looks good to me now. Thank you. @gardar do you want to take a look and test it before we merge it and ship it? |
[test] |
1 similar comment
[test] |
Haven't had a chance to test it, but it looks good to me, thanks! |
Fixes #654