Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ppc64le support #702

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Added ppc64le support #702

merged 1 commit into from
Sep 2, 2024

Conversation

Shafi-Hussain
Copy link
Contributor

Updated build-and-push to add power image builds

@frenzymadness
Copy link
Member

@phracek could you please take a look?

@Shafi-Hussain
Copy link
Contributor Author

@frenzymadness @phracek
Could we please have this PR reviewed?

If there is any other support needed, we are happy to engage.

@frenzymadness
Copy link
Member

Ping @pkubatrh and @zmiklank

@frenzymadness
Copy link
Member

I'm sorry for the delay but I'm unable to assess the impact of a change like this and I have no idea whether this is planned. We probably have to wait till Petr returns from holidays.

@frenzymadness
Copy link
Member

In the meantime, could you please explain why do you need this?

@Shafi-Hussain
Copy link
Contributor Author

@frenzymadness The change is to add ppc64le architecture s2i-python-container images.

We need ppc64le images to support building and maintaining opendatahub-io ppc64le images.
Some of opendatahub-io/notebook images use s2i-python-container as their base image which is currently not available for the aforementioned architecture.

We can wait for Petr's return.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. I was on PTO.

@phracek
Copy link
Member

phracek commented Sep 2, 2024

[test-all]

@frenzymadness frenzymadness merged commit 38421cc into sclorg:master Sep 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants