Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CI for Python 3.12 minimal container image #705

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

frenzymadness
Copy link
Member

When we merge this, I'll rebase #704

@frenzymadness frenzymadness requested a review from phracek August 14, 2024 20:46
@frenzymadness
Copy link
Member Author

@phracek ping

@phracek
Copy link
Member

phracek commented Sep 2, 2024

[test]

@@ -60,7 +60,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: [ "3.8", "3.9", "3.9-minimal", "3.11", "3.11-minimal", "3.12" ]
version: [ "3.8", "3.9", "3.9-minimal", "3.11", "3.11-minimal", "3.12", "3.12-minimal" ]
Copy link
Member

@phracek phracek Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to test it, this change has to be done as a separate PR.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comment.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was on vacation. LGTM.

@frenzymadness frenzymadness merged commit d0344cc into master Sep 2, 2024
@frenzymadness frenzymadness deleted the py312-minimal-ci branch September 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants