Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora 38 is EOL #709

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fedora 38 is EOL #709

merged 2 commits into from
Sep 11, 2024

Conversation

befeleme
Copy link
Member

@befeleme befeleme commented Sep 9, 2024

This is changed on top of #708

@befeleme
Copy link
Member Author

befeleme commented Sep 9, 2024

[test]

@befeleme
Copy link
Member Author

befeleme commented Sep 9, 2024

[test]

@befeleme
Copy link
Member Author

befeleme commented Sep 9, 2024

[test]

@befeleme
Copy link
Member Author

befeleme commented Sep 9, 2024

[test]

phracek
phracek requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove also obsoleted Dockerfiles in https://github.com/sclorg/s2i-python-container/blob/master/.github/workflows/build-and-push.yml#L57

@befeleme
Copy link
Member Author

befeleme commented Sep 9, 2024

Can you please remove also obsoleted Dockerfiles in https://github.com/sclorg/s2i-python-container/blob/master/.github/workflows/build-and-push.yml#L57

I don't see any obsolete Dockerfiles here - we still build 3.11-minimal with Centos Stream 9

@befeleme befeleme mentioned this pull request Sep 10, 2024
Merged
@frenzymadness
Copy link
Member

Can you please remove also obsoleted Dockerfiles in https://github.com/sclorg/s2i-python-container/blob/master/.github/workflows/build-and-push.yml#L57

I don't see any obsolete Dockerfiles here - we still build 3.11-minimal with Centos Stream 9

Petr was right but he pointed to an incorrect line. The file build-and-push.yml contains definitions for 3.11 and 3.11-minimal on Fedora that should be removed as well.

@befeleme
Copy link
Member Author

🤦‍♀️ I found it and removed the mentions from the CI config file and README.

frenzymadness
frenzymadness approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frenzymadness frenzymadness merged commit 621d38d into sclorg:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek requested changes

@frenzymadness frenzymadness frenzymadness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@befeleme @frenzymadness @phracek