-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 and 3.12-minimal with C10S #711
Conversation
befeleme
commented
Sep 11, 2024
- enchant and atlas-devel are no longer available in the distribution - removed them for now but without knowing what they were responsible for, I can't really tell if that's enough or we should find a replacement.
[test] |
Atlas is for linear algebra (scientific applications) and enchant is an abstraction for spell-checking. Will see what will happen without them. I don't think we have a test or an internal functionalities requiring those two so we should be fine. |
I checked the test, it just imports enchant, doesn't really do anything with it. So let's just remove it and see what happens. [test] |
Now the tests run successfully. Can we drop enchant like that? Since the C library is no longer available in the distro, whoever needs it, will have to find another way. |
Thanks for this Pull request. You do GREAT jobs. Or maybe better say AWESOME job/ |
[test] |
Waw. We are GREEN. Good job. Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The tests are GREEN
+1, LGTM |