Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaces nss_wrapper with nss_wrapper-libs #713

Merged
merged 4 commits into from
Sep 24, 2024
Merged

replaces nss_wrapper with nss_wrapper-libs #713

merged 4 commits into from
Sep 24, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Sep 18, 2024

This pull request replaces nss_wrapper with nss_wrapper-libs

Less dependency and unnecessary footprint

@phracek
This pull request replaces nss_wrapper with nss_wrapper-libs
0362e46 
Less dependency and unnecessary footprint

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Add generated sources
9e39b96 
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Sep 18, 2024

[test]

@phracek phracek requested review from befeleme and hrnciar September 18, 2024 11:22
befeleme
befeleme suggested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@befeleme befeleme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also like to change the Dockerfile-minimal.template? nss_wrapper is hardcoded there and given it's minimal, we probably want to make the footprint smaller there too.

@phracek
Copy link
Member Author

phracek commented Sep 23, 2024

I forgot to replace nss-wrapper with nss-wrapper-libs for minimal images.
This fix it da66a09

[test]

@frenzymadness
Copy link
Member

The RHEL part of the testing farm seems to be broken and none of the failures seem to be caused by the change here. If you don't plan to investigate the issue and restart the CI, feel free to merge this PR.

@phracek
Copy link
Member Author

phracek commented Sep 23, 2024

The was an Ethel (subscription manager outage), it should be fixed now.

[test]

@frenzymadness
Copy link
Member

Well, it seems the issue is still there.

@phracek
Copy link
Member Author

phracek commented Sep 24, 2024

RHEL9 - 3.9 has passed:

10:37:27                 out: 
10:37:27                 out:  [PASSED] for 'gunicorn-config-different-port-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'gunicorn-config-different-port-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'gunicorn-config-different-port-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'gunicorn-config-different-port-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-config-different-port-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-config-different-port-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-different-port-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'gunicorn-different-port-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'gunicorn-different-port-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'gunicorn-different-port-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-different-port-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-different-port-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'django-different-port-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'django-different-port-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'django-different-port-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'django-different-port-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'django-different-port-test-app' test_application_with_user (00:00:05)
10:37:27                 out:  [PASSED] for 'django-different-port-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'standalone-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'standalone-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'standalone-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'standalone-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'standalone-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'standalone-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'setup-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'setup-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'setup-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-requirements-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'setup-requirements-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'setup-requirements-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'setup-requirements-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-requirements-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-requirements-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'django-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'django-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'django-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'django-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'django-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'django-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'numpy-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'numpy-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'numpy-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'numpy-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'numpy-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'numpy-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'app-home-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'app-home-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'app-home-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'app-home-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'app-home-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'app-home-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'locale-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'locale-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'locale-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'locale-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'locale-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'locale-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'pipenv-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'pipenv-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'pipenv-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'pipenv-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'pipenv-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'pipenv-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'pipenv-and-micropipenv-should-fail-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'app-module-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'app-module-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'app-module-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'app-module-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'app-module-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'app-module-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'pyuwsgi-pipenv-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'pyuwsgi-pipenv-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'pyuwsgi-pipenv-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'pyuwsgi-pipenv-test-app' test_application (00:00:05)
10:37:27                 out:  [PASSED] for 'pyuwsgi-pipenv-test-app' test_application_with_user (00:00:05)
10:37:27                 out:  [PASSED] for 'pyuwsgi-pipenv-test-app' test_application_enable_init_wrapper (00:00:05)
10:37:27                 out:  [PASSED] for 'micropipenv-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'micropipenv-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'micropipenv-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'micropipenv-test-app' test_application (00:00:07)
10:37:27                 out:  [PASSED] for 'micropipenv-test-app' test_application_with_user (00:00:07)
10:37:27                 out:  [PASSED] for 'micropipenv-test-app' test_application_enable_init_wrapper (00:00:07)
10:37:27                 out:  [PASSED] for 'standalone-custom-pypi-index-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'standalone-custom-pypi-index-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'standalone-custom-pypi-index-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'standalone-custom-pypi-index-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'standalone-custom-pypi-index-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'standalone-custom-pypi-index-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-python-configfile-different-port-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'gunicorn-python-configfile-different-port-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'gunicorn-python-configfile-different-port-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'gunicorn-python-configfile-different-port-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-python-configfile-different-port-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'gunicorn-python-configfile-different-port-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-cfg-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'setup-cfg-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'setup-cfg-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'setup-cfg-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-cfg-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'setup-cfg-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'npm-virtualenv-uwsgi-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'npm-virtualenv-uwsgi-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'npm-virtualenv-uwsgi-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'npm-virtualenv-uwsgi-test-app' test_application (00:00:06)
10:37:27                 out:  [PASSED] for 'npm-virtualenv-uwsgi-test-app' test_application_with_user (00:00:06)
10:37:27                 out:  [PASSED] for 'npm-virtualenv-uwsgi-test-app' test_application_enable_init_wrapper (00:00:07)
10:37:27                 out:  [PASSED] for 'mod-wsgi-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'mod-wsgi-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'mod-wsgi-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'mod-wsgi-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'mod-wsgi-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'mod-wsgi-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'pin-pipenv-version-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'pin-pipenv-version-test-app' test_s2i_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'pin-pipenv-version-test-app' test_docker_run_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'pin-pipenv-version-test-app' test_application (00:00:05)
10:37:27                 out:  [PASSED] for 'pin-pipenv-version-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'pin-pipenv-version-test-app' test_application_enable_init_wrapper (00:00:05)
10:37:27                 out:  [PASSED] for 'micropipenv-requirements-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'micropipenv-requirements-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'micropipenv-requirements-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'micropipenv-requirements-test-app' test_application (00:00:05)
10:37:27                 out:  [PASSED] for 'micropipenv-requirements-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'micropipenv-requirements-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'poetry-src-layout-test-app' run_s2i_build ()
10:37:27                 out:  [PASSED] for 'poetry-src-layout-test-app' test_s2i_usage (00:00:01)
10:37:27                 out:  [PASSED] for 'poetry-src-layout-test-app' test_docker_run_usage (00:00:00)
10:37:27                 out:  [PASSED] for 'poetry-src-layout-test-app' test_application (00:00:04)
10:37:27                 out:  [PASSED] for 'poetry-src-layout-test-app' test_application_with_user (00:00:04)
10:37:27                 out:  [PASSED] for 'poetry-src-layout-test-app' test_application_enable_init_wrapper (00:00:04)
10:37:27                 out:  [PASSED] for 'var-docker' test_scl_variables_in_dockerfile (00:00:00)
10:37:27                 out:  [PASSED] for 'var-docker' test_from_dockerfile (00:00:43)

@phracek
Copy link
Member Author

phracek commented Sep 24, 2024

So we are ready to MERGE.

@frenzymadness frenzymadness merged commit efb348b into master Sep 24, 2024
19 of 20 checks passed
@frenzymadness frenzymadness deleted the replace_nss_wrapper branch September 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@befeleme befeleme befeleme approved these changes

@hrnciar hrnciar Awaiting requested review from hrnciar

Assignees
No one assigned
Labels
enhancement P3 Priority 3 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phracek @frenzymadness @befeleme