Remove and forbid redundant modifiers

Author: marcphilipp

documentation/src/test/java/example/ParameterizedTestDemo.java

@@ -381,6 +381,9 @@ public class MyArgumentsProviderWithConstructorInjection implements ArgumentsPro
 
 		private final TestInfo testInfo;
 
+		// end::ArgumentsProviderWithConstructorInjection_example[]
+		@SuppressWarnings("RedundantModifier")
+		// tag::ArgumentsProviderWithConstructorInjection_example[]
 		public MyArgumentsProviderWithConstructorInjection(TestInfo testInfo) {
 			this.testInfo = testInfo;
 		}

documentation/src/test/java/example/extensions/ParameterResolverCustomTypeDemo.java

@@ -58,7 +58,7 @@ static class WrappedInteger {
 
 		private final int value;
 
-		public WrappedInteger(int value) {
+		WrappedInteger(int value) {
 			this.value = value;
 		}
 

documentation/src/test/java/example/testinterface/TestLifecycleLogger.java

@@ -25,7 +25,7 @@
 @TestInstance(Lifecycle.PER_CLASS)
 interface TestLifecycleLogger {
 
-	static final Logger logger = Logger.getLogger(TestLifecycleLogger.class.getName());
+	Logger logger = Logger.getLogger(TestLifecycleLogger.class.getName());
 
 	@BeforeAll
 	default void beforeAllTests() {

gradle/config/checkstyle/checkstyleMain.xml

@@ -44,6 +44,7 @@
 		</module>
 		<module name="HideUtilityClassConstructor"/>
 		<module name="ModifierOrder"/>
+		<module name="RedundantModifier"/>
 		<module name="EqualsAvoidNull"/>
 		<module name="EmptyStatement"/>
 	</module>

gradle/config/checkstyle/checkstyleTest.xml

@@ -26,6 +26,7 @@
 			<property name="message" value="Please use String.formatted() (non-static) rather than String.format() (static)."/>
 			<property name="ignoreComments" value="true"/>
 		</module>
+		<module name="RedundantModifier"/>
 	</module>
 
 	<module name="SuppressWarningsFilter" />

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/config/InstantiatingConfigurationParameterConverter.java

@@ -29,7 +29,7 @@ class InstantiatingConfigurationParameterConverter<T> {
 	private final Class<T> clazz;
 	private final String name;
 
-	public InstantiatingConfigurationParameterConverter(Class<T> clazz, String name) {
+	InstantiatingConfigurationParameterConverter(Class<T> clazz, String name) {
 		this.clazz = clazz;
 		this.name = name;
 	}

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/ClassTemplateTestDescriptor.java

@@ -209,7 +209,7 @@ public JupiterEngineExecutionContext execute(JupiterEngineExecutionContext conte
 	class ClassTemplateExecutor
 			extends TemplateExecutor<ClassTemplateInvocationContextProvider, ClassTemplateInvocationContext> {
 
-		public ClassTemplateExecutor() {
+		ClassTemplateExecutor() {
 			super(ClassTemplateTestDescriptor.this, ClassTemplateInvocationContextProvider.class);
 		}
 

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/execution/ConditionEvaluationException.java

@@ -27,7 +27,7 @@ class ConditionEvaluationException extends JUnitException {
 	@Serial
 	private static final long serialVersionUID = 1L;
 
-	public ConditionEvaluationException(String message, Throwable cause) {
+	ConditionEvaluationException(String message, Throwable cause) {
 		super(message, cause);
 	}
 

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/MutableExtensionRegistry.java

@@ -294,7 +294,7 @@ private static class LateInitEntry implements Entry {
 		@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
 		private Optional<Extension> extension = Optional.empty();
 
-		public LateInitEntry(Class<?> testClass, Function<Object, ? extends Extension> initializer) {
+		LateInitEntry(Class<?> testClass, Function<Object, ? extends Extension> initializer) {
 			this.testClass = testClass;
 			this.initializer = initializer;
 		}

junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/RepeatedTestInvocationContext.java

@@ -27,8 +27,7 @@ class RepeatedTestInvocationContext implements TestTemplateInvocationContext {
 	private final DefaultRepetitionInfo repetitionInfo;
 	private final RepeatedTestDisplayNameFormatter formatter;
 
-	public RepeatedTestInvocationContext(DefaultRepetitionInfo repetitionInfo,
-			RepeatedTestDisplayNameFormatter formatter) {
+	RepeatedTestInvocationContext(DefaultRepetitionInfo repetitionInfo, RepeatedTestDisplayNameFormatter formatter) {
 
 		this.repetitionInfo = repetitionInfo;
 		this.formatter = formatter;