Skip to content

fix issue #101 #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix issue #101 #415

wants to merge 1 commit into from

Conversation

iammosespaulr
Copy link
Collaborator

@iammosespaulr iammosespaulr commented Jan 17, 2018 •
edited by agentmilindu
Loading

Fix #101
@malithsen @agentmilindu please review ..

@iammosespaulr iammosespaulr changed the title add Startup script for bassa add Startup script for bassa and fix issue https://github.com/scorelab/Bassa/issues/101 Jan 17, 2018
@iammosespaulr iammosespaulr changed the title add Startup script for bassa and fix issue https://github.com/scorelab/Bassa/issues/101 fix issue https://github.com/scorelab/Bassa/issues/101 Jan 17, 2018
@iammosespaulr iammosespaulr changed the title fix issue https://github.com/scorelab/Bassa/issues/101 fix issue https://github.com/scorelab/Bassa/issues/101 #101 Jan 17, 2018
@iammosespaulr
Copy link
Collaborator Author

@agentmilindu @malithsen Please review

@agentmilindu agentmilindu changed the title fix issue https://github.com/scorelab/Bassa/issues/101 #101 fix issue #101 Feb 18, 2018
agentmilindu
agentmilindu requested changes Feb 18, 2018
View reviewed changes
start.sh
cd ..;
cd ..;
cd ui/;
gnome-terminal -e "sudo gulp serve";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why gnome-terminal?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iammosespaulr I think that using this line should take care of both the servers:

sudo python3 components/core/Main.py & cd ui/ & sudo gulp serve;

@kmehant
Copy link
Collaborator

kmehant commented Jun 5, 2019

I don't think using gnome-terminal to execute this would be productive and is true that not all machines have it installed. I would really appreciate if you could come with a much more simple solution to start all the servers. So closing this PR for now.

@kmehant kmehant closed this Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamchopra padamchopra padamchopra left review comments

@agentmilindu agentmilindu agentmilindu requested changes

@rehrumesh rehrumesh Awaiting requested review from rehrumesh

@malithsen malithsen Awaiting requested review from malithsen

@rajikaimal rajikaimal Awaiting requested review from rajikaimal

@saisankargochhayat saisankargochhayat Awaiting requested review from saisankargochhayat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unified script to start Bassa servers at once
4 participants
@iammosespaulr @kmehant @agentmilindu @padamchopra