Erros in reading an EDF file: UnicodeEncodeError: 'ascii' codec can't encode...

[RyanY11]

I'm trying to use eyelinkio for developing my codes to analyze eye-tracking data. First I tried the default test_2_raw.edf in tests, it returned the same as README, but when I try my test data it returned UnicodeEncodeError:

UnicodeEncodeError: 'ascii' codec can't encode characters in position 26-33: ordinal not in range(128)

I tried to open and compare the two EDF in Windows Notepad, and the first 10 lines looks similar and I can't find out why it showed UnicodeEncodeError.

Do you have any idea? Many thanks!~

[drammock]

@scott-huberty this one will probably require exposing an encoding parameter to the user. Example: https://github.com/mne-tools/mne-python/pull/12730/files

[scott-huberty]

Thanks for the detailed report @RyanY11 and Thanks for the tip @drammock !

@RyanY11 Feel free to open a PR that fixes this if you have the time, otherwise I will do it as soon as I can... Probably this week.

[RyanY11]

Thanks a lot for the quick reply! @scott-huberty @drammock

I switched encoding 'ASCII' to 'utf8', now it works as expected and I can get the returns.

[scott-huberty]

Hi @RyanY11 I noticed that you pushed some couple commits on your fork to add an seconding parameter to read_edf. Nice!

Do you plan to open a Pull Request to merge your changes? I am just checking so that we don't duplicate our efforts. If you do not have time to work on this, then I will push a fix.

[RyanY11]

Really sorry about this Scott! I just saw your message...
I initially intended to submit a pull request to update the changes, but just realized I wasn't familiar with the testing part in this project, and it was also my first time submitting a PR. So I put it on hold for a while and wrote my code data analysis work first.
If you've already prepared the fix, please push it. That would be great and quick.
P.S. Many thanks to the eyelinkio project. It helps my work a lot! And I'm interested in this project, hope to contribute in the future.