get_trend_data method doesn't return anything

[cholmescanada]

sense/sense_energy/senseable.py

Line 192 in 9b46e7a

def get_trend_data(self, scale, dt=None):

I am not able to get any data from sense.get_trend_data('DAY') even after running sense.update_trend_data()

I am able to authenticate and have other device usage data returned such as sense.daily_usage

Apologies if this is just an error on my end - would appreciate any help.

Thanks!

[kbickar]

The data resets at midnight, maybe it works for you now?
You can dump it all to see with print(sense._trend_data["DAY"])

[cholmescanada]

Thanks for the reply! When I try that, I do get an output.

I am sure this is a problem with my understanding, however what I am looking to do is get usage data on a certain date. I see in the code it allows specifying a date, however I am unable to get anything to return.

`import datetime
from sense_energy import Senseable
sense = Senseable()
sense.authenticate('', '')

my_date = datetime.datetime(2023, 4, 2)
test = sense.get_trend_data('DAY',my_date)
print(test)`

and I get "None" as the output.

Thanks in advance!

[sagararthonsys]

I am not able to get any data from sense.get_trend_data('DAY') even after running sense.update_trend_data()

[dauc]

sense.get_trend_data doesn't actually return the trend data; it just retrieves it and stores it in sense._trend_data.

Based on the other get_ functions maybe it should return self._trend_data[scale] ? But it works to call and then read the result from self._trend_data[scale] directly.

[snairolf]

Agree, the naming is inconsistent. Based on the other functions get_trend_data() should just do the api call and not change the internal _trend_data.

Instead, update_trend_data could have a scales=[] input parameter, or similar.

[kbickar]

I guess get_trend_data() should really be an internal function or renamed to update_single_trend_data() or something. The function get_trend() should be used to retrieve trend data after it's been updated

[snairolf]

Renaming to update_single_trend_data() would make sense. It would still be good to keep get_trend_data() in line with all the other functions that just return the raw data from the API call.

Currently, it's quite mixed which functions return values AND modify internal data versus the ones that just return the raw data from the call (modifying internal data: get_trend_data(), get_discovered_device_names(), get_monitor_data()). IMHO, it would be good to have a better separation in terms of naming between the functions that do an API call vs the ones that don't.

[kbickar]

The reason for that is the get_discovered_device_names() and get_monitor_data() are API calls that would likely be called only once per session while the ones like get_trend() would return the data from the last time it was updated (which might happen once a minute or more). The get_trend() could be called quite frequently while there's not much reason to call the others more than once

Renaming that function and a doc update would work here