Skip to content

Commit b5f5c9d

Browse files
scottdhughesclaude
andcommitted
fix: mypy type regression in _benchmark_classical
Rename variables in X25519/Ed25519 branches to avoid type conflict across if/elif branches (sk was X25519PrivateKey in one branch and Ed25519PrivateKey in the other). Codex AM review finding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c8de13c commit b5f5c9d

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

pqc_mcp_server/handlers_pqc.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -461,16 +461,16 @@ def _benchmark_classical(algorithm: str, iterations: int) -> dict[str, Any]:
461461
# Keygen
462462
t0 = time.perf_counter()
463463
for _ in range(iterations):
464-
sk = X25519PrivateKey.generate()
465-
sk.public_key()
464+
x_sk = X25519PrivateKey.generate()
465+
x_sk.public_key()
466466
keygen_ms = (time.perf_counter() - t0) / iterations * 1000
467467

468468
# Key exchange
469-
sk1 = X25519PrivateKey.generate()
470-
pk2 = X25519PrivateKey.generate().public_key()
469+
x_sk1 = X25519PrivateKey.generate()
470+
x_pk2 = X25519PrivateKey.generate().public_key()
471471
t0 = time.perf_counter()
472472
for _ in range(iterations):
473-
sk1.exchange(pk2)
473+
x_sk1.exchange(x_pk2)
474474
exchange_ms = (time.perf_counter() - t0) / iterations * 1000
475475

476476
return {
@@ -485,22 +485,22 @@ def _benchmark_classical(algorithm: str, iterations: int) -> dict[str, Any]:
485485
# Keygen
486486
t0 = time.perf_counter()
487487
for _ in range(iterations):
488-
sk = Ed25519PrivateKey.generate()
489-
sk.public_key()
488+
ed_sk = Ed25519PrivateKey.generate()
489+
ed_sk.public_key()
490490
keygen_ms = (time.perf_counter() - t0) / iterations * 1000
491491

492492
# Sign
493-
sk = Ed25519PrivateKey.generate()
493+
ed_sk = Ed25519PrivateKey.generate()
494494
t0 = time.perf_counter()
495495
for _ in range(iterations):
496-
sig = sk.sign(test_message)
496+
ed_sig = ed_sk.sign(test_message)
497497
sign_ms = (time.perf_counter() - t0) / iterations * 1000
498498

499499
# Verify
500-
pk = sk.public_key()
500+
ed_pk = ed_sk.public_key()
501501
t0 = time.perf_counter()
502502
for _ in range(iterations):
503-
pk.verify(sig, test_message)
503+
ed_pk.verify(ed_sig, test_message)
504504
verify_ms = (time.perf_counter() - t0) / iterations * 1000
505505

506506
return {

0 commit comments

Comments
 (0)