- 
                Notifications
    
You must be signed in to change notification settings  - Fork 155
 
Open
Labels
Description
There were multiple issues identified with the code of SelectorList itself, Selector.selectorlist_cls and their typing. Ideally:
SelectorListshould only be able to containSelectorobjectsSelectorListsubclasses made to work withSelectorsubclasses should only able to contain thoseSelectorsubclasses shouldn't need to setselectorlist_clsto a respectiveSelectorListsubclass manually- all of this should be properly typed without need for casts and other overrides
 
This may require changing Selector and/or SelectorList base classes, but I think we will need to keep the API compatibility? It's also non-trivial because the API for subclassing them doesn't seem to be documented, the only reference is SelectorTestCase.test_extending_selector() (the related code was also changed when adding typing, not sure if it changed the interface).