Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the config a component of the app #526

Open
jpmckinney opened this issue Jul 20, 2024 · 1 comment
Open

Make the config a component of the app #526

jpmckinney opened this issue Jul 20, 2024 · 1 comment
Labels
type: enhancement

Comments

@jpmckinney
Copy link
Contributor

jpmckinney commented Jul 20, 2024 •
edited
Loading

So that other components can get the config options directly from it.

For example, the poller and scheduler currently store the config, so that they can call get_spider_queues with it.

First mentioned in #186
@jpmckinney jpmckinney added this to the Priority milestone Jul 20, 2024
@jpmckinney
Copy link
Contributor Author

jpmckinney commented Jul 21, 2024 •
edited
Loading

Temporarily added Root._config.

See the TODO and links to https://github.com/scrapy/scrapyd/issues/526 in the code.

jpmckinney added a commit that referenced this issue Jul 21, 2024
@jpmckinney
feat: get_spider_list() (used by Schedule and ListSpiders) supports t…
94e87da 
…he [settings] section. Add Root._config (hack) #526. chore: Root has the correct default for runner, if it were somehow not configured.
@jpmckinney jpmckinney removed this from the Priority milestone Jul 22, 2024
jpmckinney added a commit that referenced this issue Jul 22, 2024
@jpmckinney
Revert "get_spider_list() (used by Schedule and ListSpiders) supports…
88e2d87 
… the [settings] section. Add Root._config (hack) #526" 94e87da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpmckinney