Call fixupSvgString on all SVGs

[fsih]

Expected Behavior

fixupSvgString fixes common issues that make SVGs invalid. Probably any SVG uploaded to Scratch should have these fixes applied. This way, Scratch would support more SVGs.
https://github.com/LLK/scratch-svg-renderer/blob/9ebf57588aa596c4fa3bb64209e10ade395aee90/src/fixup-svg-string.js#L51

Actual Behavior

fixupSvgString is currently only called if optVersion == 2 here (i.e. when loading a sb2 or sprite2)
https://github.com/LLK/scratch-vm/blob/e63993257210ce9f3a66ac764f7f4b1941f63fa5/src/import/load-costume.js#L10

Describe what actually happens

Steps to Reproduce

Explain what someone needs to do in order to see what's described in Actual behavior above

Operating System and Browser

e.g. Mac OS 10.11.6 Safari 10.0

[kchadha]

From our discussion offline -- would this cause us to resave all of our vector assets?

[fsih]

We should check to not resave if the asset hasn't been changed by fixup SVG string. Then as long as the SVG doesn't have any forbidden elements, it won't be resaved. There shouldn't be too many SVGs like that. See https://github.com/LLK/scratch-svg-renderer/blob/develop/src/fixup-svg-string.js

[apple502j]

Currently all v2 SVGs are marked as dirty. We can fix this.
0001-Always-call-v2SvgAdapter.patch.txt

[apple502j]

@fsih It seems like there are still some "question mark" problems lying around (according to BaG) - I hope this is why?

See above for solutions to bandwidth problem. (am I the only one who thinks the 5 million dollar from Google should be spent on general maintenance as well, not just the webinar?)

[fsih]

Reverted by scratchfoundation/scratch-vm#3026