Skip to content

Commit 33b4b1c

Browse files
committed
require all reduced_openings are consumed
1 parent 608a6c9 commit 33b4b1c

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

crates/mpcs/src/basefold/query_phase.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,9 @@ pub fn batch_verifier_query_phase<E: ExtensionField, S: EncodingScheme<E>>(
223223
let folded_idx = idx & 0x01;
224224
let mut leafs = vec![*sibling_value; 2];
225225
leafs[folded_idx] = folded;
226-
if let Some(eval) = reduced_openings_by_height[log2_height] {
226+
227+
let ro = std::mem::take(&mut reduced_openings_by_height[log2_height]);
228+
if let Some(eval) = ro {
227229
leafs[folded_idx] += eval;
228230
}
229231

@@ -247,6 +249,10 @@ pub fn batch_verifier_query_phase<E: ExtensionField, S: EncodingScheme<E>>(
247249
log2_height -= 1;
248250
idx >>= 1;
249251
}
252+
assert!(
253+
reduced_openings_by_height.iter().all(|v| v.is_none()),
254+
"there are unused openings remain",
255+
);
250256
assert!(
251257
final_codeword.values[idx] == folded,
252258
"final_codeword.values[idx] value {:?} != folded {:?}",

0 commit comments

Comments
 (0)