Skip to content

Commit 88d3f40

Browse files
committed
simplify api
1 parent a0224e5 commit 88d3f40

File tree

1 file changed

+19
-3
lines changed
  • crates/multilinear_extensions/src/expression

1 file changed

+19
-3
lines changed

crates/multilinear_extensions/src/expression/utils.rs

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,6 @@ pub const DagMul: usize = 3;
198198

199199
pub fn expr_compression_to_dag<E: ExtensionField>(
200200
expr: &Expression<E>,
201-
challenges_offset: usize,
202-
constant_offset: usize,
203201
) -> (
204202
Vec<u32>,
205203
Vec<Instance>,
@@ -211,10 +209,28 @@ pub fn expr_compression_to_dag<E: ExtensionField>(
211209
let mut constant = vec![];
212210
let mut instance_scalar = vec![];
213211
let mut challenges = vec![];
212+
// traverse first time to collect offset
213+
let _ = expr_compression_to_dag_helper(
214+
&mut dag,
215+
&mut instance_scalar,
216+
0,
217+
&mut challenges,
218+
0,
219+
&mut constant,
220+
expr,
221+
);
222+
223+
let challenge_offset = instance_scalar.len();
224+
let constant_offset = instance_scalar.len() + challenges.len();
225+
226+
dag.truncate(0);
227+
constant.truncate(0);
228+
instance_scalar.truncate(0);
229+
challenges.truncate(0);
214230
let (max_degree, max_depth) = expr_compression_to_dag_helper(
215231
&mut dag,
216232
&mut instance_scalar,
217-
challenges_offset,
233+
challenge_offset,
218234
&mut challenges,
219235
constant_offset,
220236
&mut constant,

0 commit comments

Comments
 (0)