Skip to content

Commit 072c433

Browse files
authored
Revert "Backport PR #1626: (chore): automation of towncrier release process (…" (#1741)
This reverts commit 7d48a8a.
1 parent 7d48a8a commit 072c433

4 files changed

Lines changed: 1 addition & 136 deletions

File tree

ci/scripts/towncrier_automation.py

Lines changed: 0 additions & 110 deletions
This file was deleted.

docs/contributing.md

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,6 @@ AnnData follows the development practices outlined in the [Scanpy contribution g
66
.. include:: _key_contributors.rst
77
```
88

9-
## Release Notes
10-
11-
AnnData differs from `scanpy` (for now) in how its releases are done.
12-
It uses [towncrier][] to build its changelog.
13-
We have set up some automation around this process.
14-
To run `towncrier`, create a `PR` into the base branch of the release with the compiled changelog, and backport to `main` if needed (i.e., the base branch is something like `0.10.x`), run
15-
16-
```shell
17-
hatch run towncrier:build X.Y.Z
18-
```
19-
20-
You may add the option `--dry-run` at the end to do the local steps without pushing to Github, although the push will be mocked via [`gh pr --dry-run`](https://cli.github.com/manual/gh_pr_create).
21-
22-
[towncrier]: https://towncrier.readthedocs.io/en/stable/
23-
249
## CI
2510

2611
### GPU CI

pyproject.toml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,9 @@ select = [
169169
"E", # Error detected by Pycodestyle
170170
"F", # Errors detected by Pyflakes
171171
"W", # Warning detected by Pycodestyle
172-
"PLW", # Pylint
173172
"UP", # pyupgrade
174173
"I", # isort
175174
"TCH", # manage type checking blocks
176-
"TID", # Banned imports
177175
"ICN", # Follow import conventions
178176
"PTH", # Pathlib instead of os.path
179177
"PT", # Pytest conventions
@@ -185,21 +183,13 @@ ignore = [
185183
"E731",
186184
# allow I, O, l as variable names -> I is the identity matrix, i, j, k, l is reasonable indexing notation
187185
"E741",
188-
# We use relative imports from parent modules
189-
"TID252",
190-
# Shadowing loop variables isn’t a big deal
191-
"PLW2901",
192186
]
193187
[tool.ruff.lint.per-file-ignores]
194188
# E721 comparing types, but we specifically are checking that we aren't getting subtypes (views)
195189
"tests/test_readwrite.py" = ["E721"]
196190
[tool.ruff.lint.isort]
197191
known-first-party = ["anndata"]
198192
required-imports = ["from __future__ import annotations"]
199-
[tool.ruff.lint.flake8-tidy-imports.banned-api]
200-
"subprocess.call".msg = "Use `subprocess.run([…])` instead"
201-
"subprocess.check_call".msg = "Use `subprocess.run([…], check=True)` instead"
202-
"subprocess.check_output".msg = "Use `subprocess.run([…], check=True, capture_output=True)` instead"
203193
[tool.ruff.lint.flake8-type-checking]
204194
exempt-modules = []
205195
strict = true

src/anndata/logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def get_memory_usage():
3131
meminfo = process.get_memory_info()
3232
mem = meminfo[0] / 2**30 # output in GB
3333
mem_diff = mem
34-
global _previous_memory_usage # noqa: PLW0603
34+
global _previous_memory_usage
3535
if _previous_memory_usage is not None:
3636
mem_diff = mem - _previous_memory_usage
3737
_previous_memory_usage = mem

0 commit comments

Comments
 (0)