Enable new linters and tweak some suboptimal patterns#453
Merged
Conversation
|
Bencher Report| Branch | minor-performance-tweaks |
| Testbed | ubuntu-latest |
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
Bisaloo
force-pushed
the
minor-performance-tweaks
branch
from
075b4fc to
f32f9d6
Compare
Member
|
Some of the changes improve readability, others decrease it. It seems like the proposed changes all use base R functions that were added quite a long time ago, so I'm not that concerned. @Bisaloo There is a linter check failing; could you fix that before I approve the PR? |
rcannood
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
Description
I'm profiling
SpatialData::readSpatialData()code and while most improvements will come from Rarr (WIP), I noticed some patterns that might also be improved in anndataR.I also enabled some extra linters so these patterns are not reintroduced in the future.
Each commit focuses on a specific pattern so it may be easier to review this PR commit by commit.
Checklist
Before review
Before merge
NEWS