Fix logging for existing PRs

grst · grst · commit 605f95714130 · 2023-08-16T08:31:54.000+02:00
diff --git a/scripts/src/scverse_template_scripts/cruft_prs.py b/scripts/src/scverse_template_scripts/cruft_prs.py
@@ -223,7 +223,7 @@ def make_pr(con: GitHubConnection, release: GHRelease, repo_url: str) -> None:
     origin = con.gh.get_repo(repo_url.removeprefix("https://github.com/"))
     repo = get_fork(con, origin)
 
-    if any(True for p in origin.get_pulls("open") if pr.matches_current_version(p)):
+    if old_pr := next((p for p in origin.get_pulls("open") if pr.matches_current_version(p)), None):
         log.info(
             f"PR for current version already exists: #{old_pr.number} with branch name `{old_pr.head.ref}`. Skipping."
         )

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ def make_pr(con: GitHubConnection, release: GHRelease, repo_url: str) -> None:`
`223`	`223`	`origin = con.gh.get_repo(repo_url.removeprefix("https://github.com/"))`
`224`	`224`	`repo = get_fork(con, origin)`
`225`	`225`
`226`		`- if any(True for p in origin.get_pulls("open") if pr.matches_current_version(p)):`
	`226`	`+ if old_pr := next((p for p in origin.get_pulls("open") if pr.matches_current_version(p)), None):`
`227`	`227`	`log.info(`
`228`	`228`	f"PR for current version already exists: #{old_pr.number} with branch name `{old_pr.head.ref}`. Skipping."
`229`	`229`	`)`