Skip to content

Commit db2eba5

Browse files
committed
add release note and up blocksort size
1 parent 4df6b7a commit db2eba5

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

docs/release-notes/0.15.1.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
```{rubric} Bug fixes
99
```
1010
* Fixes `tl.rank_genes_groups` returning NaN/zero `logfoldchanges`/`pvals` with `groups=[subset]` and `reference='rest'` {pr}`651` {smaller}`S Dicks`
11+
* Fixes `pp.bbknn` connectivities diverging from upstream `bbknn`: per-batch neighbours are now sorted by distance before `fuzzy_simplicial_set` (so weights no longer collapse near 1.0), and the default `trim` matches upstream (`10 * neighbors_within_batch * n_batches`). Trimming kernel no longer crashes for large `trim`, and a new block-cooperative sort kernel is auto-dispatched for large `trim` for substantial speedups {pr}`659` {smaller}`S Dicks`
1112

1213
```{rubric} Misc
1314
```

src/rapids_singlecell/_cuda/bbknn/bbknn.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
using namespace nb::literals;
77

88
constexpr int BLOCK_SIZE = 64;
9-
// Block-cooperative sort kernel: BLOCK_THREADS * ITEMS_PER_THREAD = 1024.
9+
// Block-cooperative sort kernel: BLOCK_THREADS * ITEMS_PER_THREAD = 2048.
1010
// Rows larger than this must use the per-thread kernel (kernel 1).
1111
constexpr int SORT_BLOCK_THREADS = 128;
12-
constexpr int SORT_ITEMS_PER_THREAD = 8;
12+
constexpr int SORT_ITEMS_PER_THREAD = 16;
1313
constexpr int SORT_TILE_SIZE = SORT_BLOCK_THREADS * SORT_ITEMS_PER_THREAD;
1414

1515
static inline void launch_find_top_k_per_row(const float* data,

0 commit comments

Comments
 (0)