Skip to content

_create_adata in test_score_genes doesen't work properly #3580

Closed
@Reovirus

Description

@Reovirus

What kind of feature would you like to request?

Additional function parameters / changed functionality / changed defaults?

Please describe your wishes

_create_random_gene_names have no checks to name unique, as a result we have gene name duplicates and errors like pandas.errors.InvalidIndexError: Reindexing only valid with uniquely valued Index objects when testing

  1. Fixed random seed is needed to test reproducibility
  2. Rewrite function

Maybe we should use set.add and check set length

Activity

changed the issue type fromtoon Apr 14, 2025
flying-sheep

flying-sheep commented on Apr 14, 2025

@flying-sheep
Member

For sure! I came up with something in #3590. Check it out if you want!

added this to the 1.11.2 milestone on Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Relationships

    None yet

    Participants

    @flying-sheep@Reovirus

    Issue actions

      _create_adata in test_score_genes doesen't work properly · Issue #3580 · scverse/scanpy