chore: add in accessors to silence deprecation warnings#3974
Merged
Conversation
ilan-gold
force-pushed
the
ig/deprecate_obs_vector
branch
from
d234850 to
28c3e44
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
+ Coverage 78.26% 78.28% +0.01%
==========================================
Files 117 117
Lines 12634 12634
==========================================
+ Hits 9888 9890 +2
+ Misses 2746 2744 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilan-gold
commented
Feb 13, 2026
|
|
||
| adata.obs["1_missing"] = adata.obs_vector("1") | ||
| # TODO: If we don't `copy`, something about this being an ArrayView means that all values get set to nan? | ||
| adata.obs["1_missing"] = adata[:, "1"].X.flatten().copy() |
Contributor
Author
There was a problem hiding this comment.
We need to get rid of views
ilan-gold
changed the title
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Feb 16, 2026
flying-sheep
pushed a commit
that referenced
this pull request
Feb 16, 2026
…e deprecation warnings) (#3976) Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.