Add vector support #592
Merged
Add vector support #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@dkropachev This is wip, I still need to merge apache#1899 but it is not that obvious due to how different upstream and our fork is regarding marshaling. |
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
2 times, most recently
from
66d53fb to
70d3c23
Compare
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
from
70d3c23 to
1a679c4
Compare
Collaborator
Author
|
@dkropachev it is ready for your review |
dkropachev
requested changes
Oct 21, 2025
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
3 times, most recently
from
da52975 to
ff54760
Compare
Collaborator
Author
|
The CI is failing on these tests: not sure why, the errors look like this: |
Collaborator
|
@sylwiaszunejko , could you please rebase and address test and build failures. |
Collaborator
Author
|
CI fails due to scylladb/scylladb#26704 |
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
from
ff54760 to
ef211bd
Compare
Collaborator
Can you please mark these tests to have them skipped unit next scylla version, while rest of vector tests to be run on current one |
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
from
2710059 to
e1e9381
Compare
Support marshalling and unmarshalling of vector custom type. patched by Lukasz Antoniak; reviewed by João Reis, Stanislav Bychkov, Oleksandr Luzhniy, Mykyta Oleksiienko and Bohdan Siryk for CASSGO-11
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
from
e1e9381 to
8947348
Compare
dkropachev
requested changes
Oct 29, 2025
Tinyint unmarshal silently errors and unmarshals tinyint values as 0 in some situations. This patch also removes other cases of silent errors in decode functions. Fix issue where reading vectors with SliceMap is not possible. Patch by João Reis; reviewed by James Hartig for CASSGO-82, CASSGO-83
…in vector_test xd
INSERTing Vector<collection> results in ServerError scylladb/scylladb#26704
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
from
8947348 to
3232116
Compare
sylwiaszunejko
force-pushed
the
add-vetor-support
branch
from
3232116 to
59575d8
Compare
Collaborator
|
@sylwiaszunejko , on scylla: |
dkropachev
requested changes
Nov 1, 2025
Collaborator
dkropachev
left a comment
dkropachev
left a comment
There was a problem hiding this comment.
fix the test and it is good to go
Collaborator
Author
|
@dkropachev CI fixed |
dkropachev
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to add vector support to scylladb's fork of gocql by merging upstream commits.
Fixes: #585