Skip to content

Commit dbab958

Browse files
committed
Fix session leak in PeersV2NodeRefreshIT test
PeersV2NodeRefreshIT#should_successfully_send_peers_v2_node_refresh_query integration test does not close its test session, leading to leaks when integration tests suite is executed in CI. This affects SessionLeakIT#should_warn_when_session_count_exceeds_threshold test, which sees the leaked session and fails due to an unexpected number of active sessions. The change adds post-test cleanup in PeersV2NodeRefreshIT to ensure that session is properly closed after the test, preventing it from affecting subsequent tests.
1 parent e561a2d commit dbab958

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

Diff for: integration-tests/src/test/java/com/datastax/oss/driver/core/PeersV2NodeRefreshIT.java

+10-2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.datastax.oss.simulacron.server.BoundCluster;
2828
import com.datastax.oss.simulacron.server.Server;
2929
import java.util.concurrent.ExecutionException;
30+
import org.junit.After;
3031
import org.junit.AfterClass;
3132
import org.junit.BeforeClass;
3233
import org.junit.Test;
@@ -36,6 +37,7 @@ public class PeersV2NodeRefreshIT {
3637

3738
private static Server peersV2Server;
3839
private static BoundCluster cluster;
40+
private static CqlSession session;
3941

4042
@BeforeClass
4143
public static void setup() {
@@ -53,11 +55,17 @@ public static void tearDown() {
5355
}
5456
}
5557

58+
@After
59+
public void closeSession() {
60+
if (session != null) {
61+
session.close();
62+
}
63+
}
64+
5665
@Test
5766
public void should_successfully_send_peers_v2_node_refresh_query()
5867
throws InterruptedException, ExecutionException {
59-
CqlSession session =
60-
CqlSession.builder().addContactPoint(cluster.node(1).inetSocketAddress()).build();
68+
session = CqlSession.builder().addContactPoint(cluster.node(1).inetSocketAddress()).build();
6169
Node node = findNonControlNode(session);
6270
((InternalDriverContext) session.getContext())
6371
.getMetadataManager()

0 commit comments

Comments
 (0)