fix several deprecation warnings

adding -Werror flag to pytest configuration
so we can flush all of those with the test we have
so we won't have user of the driver running into those
and get them fixed address as soon as we support new
python versions

Author: fruch

cassandra/cqlengine/connection.py

@@ -324,7 +324,7 @@ def setup(
     :param int consistency: The global default :class:`~.ConsistencyLevel` - default is the same as :attr:`.Session.default_consistency_level`
     :param bool lazy_connect: True if should not connect until first use
     :param bool retry_connect: True if we should retry to connect even if there was a connection failure initially
-    :param \*\*kwargs: Pass-through keyword arguments for :class:`cassandra.cluster.Cluster`
+    :param kwargs: Pass-through keyword arguments for :class:`cassandra.cluster.Cluster`
     """
 
     from cassandra.cqlengine import models

cassandra/cqlengine/query.py

@@ -206,8 +206,8 @@ def add_callback(self, fn, *args, **kwargs):
 
         :param fn: Callable object
         :type fn: callable
-        :param \*args: Positional arguments to be passed to the callback at the time of execution
-        :param \*\*kwargs: Named arguments to be passed to the callback at the time of execution
+        :param args: Positional arguments to be passed to the callback at the time of execution
+        :param kwargs: Named arguments to be passed to the callback at the time of execution
         """
         if not callable(fn):
             raise ValueError("Value for argument 'fn' is {0} and is not a callable object.".format(type(fn)))
@@ -277,8 +277,8 @@ class ContextQuery(object):
     A Context manager to allow a Model to switch context easily. Presently, the context only
     specifies a keyspace for model IO.
 
-    :param \*args: One or more models. A model should be a class type, not an instance.
-    :param \*\*kwargs: (optional) Context parameters: can be *keyspace* or *connection*
+    :param args: One or more models. A model should be a class type, not an instance.
+    :param kwargs: (optional) Context parameters: can be *keyspace* or *connection*
 
     For example:
 

cassandra/datastax/cloud/__init__.py

@@ -23,7 +23,7 @@
 
 _HAS_SSL = True
 try:
-    from ssl import SSLContext, PROTOCOL_TLS, CERT_REQUIRED
+    from ssl import SSLContext, PROTOCOL_TLS_CLIENT, CERT_REQUIRED
 except:
     _HAS_SSL = False
 
@@ -170,7 +170,7 @@ def parse_metadata_info(config, http_data):
 
 
 def _ssl_context_from_cert(ca_cert_location, cert_location, key_location):
-    ssl_context = SSLContext(PROTOCOL_TLS)
+    ssl_context = SSLContext(PROTOCOL_TLS_CLIENT)
     ssl_context.load_verify_locations(ca_cert_location)
     ssl_context.verify_mode = CERT_REQUIRED
     ssl_context.load_cert_chain(certfile=cert_location, keyfile=key_location)

cassandra/util.py

@@ -34,7 +34,7 @@
 from cassandra import DriverException
 
 DATETIME_EPOC = datetime.datetime(1970, 1, 1)
-UTC_DATETIME_EPOC = datetime.datetime.utcfromtimestamp(0)
+UTC_DATETIME_EPOC = datetime.datetime.fromtimestamp(0,  tz=datetime.timezone.utc)
 
 _nan = float('nan')
 

pytest.ini

@@ -3,3 +3,13 @@ log_format = %(asctime)s.%(msecs)03d %(levelname)s [%(module)s:%(lineno)s]: %(me
 log_level = DEBUG
 log_date_format = %Y-%m-%d %H:%M:%S
 xfail_strict=true
+
+filterwarnings =
+    error
+    ignore::pytest.PytestCollectionWarning
+    ignore::ResourceWarning
+    ignore:distutils Version classes are deprecated:DeprecationWarning:eventlet.support.greenlets
+    ignore:X509Extension support in pyOpenSSL is deprecated.:DeprecationWarning
+    ignore:CRL support in pyOpenSSL is deprecated:DeprecationWarning
+    ignore:sign\(\) is deprecated:DeprecationWarning
+    ignore:verify\(\) is deprecated:DeprecationWarning

tests/integration/cqlengine/__init__.py

@@ -77,7 +77,7 @@ def wrapped_function(*args, **kwargs):
             # DeMonkey Patch our code
             cassandra.cqlengine.connection.execute = original_function
             # Check to see if we have a pre-existing test case to work from.
-            if len(args) is 0:
+            if len(args) == 0:
                 test_case = unittest.TestCase("__init__")
             else:
                 test_case = args[0]

tests/integration/cqlengine/query/test_queryoperators.py

@@ -154,6 +154,6 @@ def test_named_table_pk_token_function(self):
         query = named.all().limit(1)
         first_page = list(query)
         last = first_page[-1]
-        self.assertTrue(len(first_page) is 1)
+        self.assertTrue(len(first_page) == 1)
         next_page = list(query.filter(pk__token__gt=functions.Token(last.key)))
-        self.assertTrue(len(next_page) is 1)
+        self.assertTrue(len(next_page) == 1)

tests/integration/standard/test_connection.py

@@ -191,7 +191,7 @@ def wait_for_no_connections(self, host, cluster):
         while(retry < 100):
             retry += 1
             connections = self.fetch_connections(host, cluster)
-            if len(connections) is 0:
+            if len(connections) == 0:
                 return
             time.sleep(.5)
         self.fail("Connections never cleared")

tests/unit/advanced/test_graph.py

@@ -257,6 +257,7 @@ def test_with_graph_protocol(self):
 
     def test_init_unknown_kwargs(self):
         with warnings.catch_warnings(record=True) as w:
+            warnings.simplefilter("always")
             GraphOptions(unknown_param=42)
         self.assertEqual(len(w), 1)
         self.assertRegex(str(w[0].message), r"^Unknown keyword.*GraphOptions.*")

tests/unit/advanced/test_insights.py

@@ -14,6 +14,7 @@
 
 
 import unittest
+import pytest
 
 import logging
 from mock import sentinel
@@ -103,6 +104,7 @@ def superclass_sentinel_serializer(obj):
 class TestConfigAsDict(unittest.TestCase):
 
     #  graph/query.py
+    @pytest.mark.filterwarnings("ignore:Unknown keyword argument received for GraphOptions:UserWarning")
     def test_graph_options(self):
         self.maxDiff = None
 

tests/unit/advanced/test_policies.py

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 import unittest
+import pytest
 
 from mock import Mock
 
@@ -29,6 +30,7 @@ def get_host(self, addr):
         return self.hosts.get(addr)
 
 
+@pytest.mark.filterwarnings("ignore:DSELoadBalancingPolicy will be removed:DeprecationWarning")
 class DSELoadBalancingPolicyTest(unittest.TestCase):
 
     def test_no_target(self):

tests/unit/cython/bytesio_testhelper.pyx

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# cython: language_level=3
+
 from cassandra.bytesio cimport BytesIOReader
 
 def test_read1(assert_equal, assert_raises):

tests/unit/cython/types_testhelper.pyx

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# cython: language_level=3
+
 import calendar
 import datetime
 import time

tests/unit/cython/utils_testhelper.pyx

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# cython: language_level=3
+
 import datetime
 
 from cassandra.cython_utils cimport datetime_from_timestamp

tests/unit/io/utils.py

@@ -123,7 +123,7 @@ def submit_and_wait_for_completion(unit_test, create_timer, start, end, incremen
         pending_callbacks.append(callback)
 
     # wait for all the callbacks associated with the timers to be invoked
-    while len(pending_callbacks) is not 0:
+    while len(pending_callbacks) != 0:
         for callback in pending_callbacks:
             if callback.was_invoked():
                 pending_callbacks.remove(callback)
@@ -233,7 +233,7 @@ def make_error_body(self, code, msg):
     def make_msg(self, header, body=binary_type()):
         return header + uint32_pack(len(body)) + body
 
-    def test_successful_connection(self):
+    def _test_successful_connection(self):
         c = self.make_connection()
 
         # let it write the OptionsMessage
@@ -255,6 +255,9 @@ def test_successful_connection(self):
         self.assertTrue(c.connected_event.is_set())
         return c
 
+    def test_successful_connection(self):
+        self._test_successful_connection()
+
     def test_eagain_on_buffer_size(self):
         self._check_error_recovery_on_buffer_size(errno.EAGAIN)
 
@@ -272,7 +275,7 @@ def test_sslwantwrite_on_buffer_size(self):
             error_class=ssl.SSLError)
 
     def _check_error_recovery_on_buffer_size(self, error_code, error_class=socket_error):
-        c = self.test_successful_connection()
+        c = self._test_successful_connection()
 
         # current data, used by the recv side_effect
         message_chunks = None

tests/unit/test_cluster.py

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 import unittest
+import pytest
 
 import logging
 import six
@@ -275,6 +276,9 @@ def test_default_exec_parameters(self):
         self.assertEqual(cluster.profile_manager.default.row_factory, named_tuple_factory)
 
     @mock_session_pools
+    @pytest.mark.filterwarnings("ignore:DowngradingConsistencyRetryPolicy:DeprecationWarning")
+    @pytest.mark.filterwarnings("ignore:Legacy execution parameters will be removed in 4.0:DeprecationWarning")
+    @pytest.mark.filterwarnings("ignore:Setting the consistency level at the session level will be removed in 4.0:DeprecationWarning")
     def test_default_legacy(self):
         cluster = Cluster(load_balancing_policy=RoundRobinPolicy(), default_retry_policy=DowngradingConsistencyRetryPolicy())
         self.assertEqual(cluster._config_mode, _ConfigMode.LEGACY)
@@ -322,6 +326,8 @@ def test_serial_consistency_level_validation(self):
             ep = ExecutionProfile(RoundRobinPolicy(), serial_consistency_level=42)
 
     @mock_session_pools
+    @pytest.mark.filterwarnings("ignore:DowngradingConsistencyRetryPolicy:DeprecationWarning")
+    @pytest.mark.filterwarnings("ignore:Legacy execution parameters will be removed in 4.0:DeprecationWarning")
     def test_statement_params_override_legacy(self):
         cluster = Cluster(load_balancing_policy=RoundRobinPolicy(), default_retry_policy=DowngradingConsistencyRetryPolicy())
         self.assertEqual(cluster._config_mode, _ConfigMode.LEGACY)
@@ -343,6 +349,7 @@ def test_statement_params_override_legacy(self):
         self._verify_response_future_profile(rf, expected_profile)
 
     @mock_session_pools
+    @pytest.mark.filterwarnings("ignore:DowngradingConsistencyRetryPolicy:DeprecationWarning")
     def test_statement_params_override_profile(self):
         non_default_profile = ExecutionProfile(RoundRobinPolicy(), *[object() for _ in range(2)])
         cluster = Cluster(execution_profiles={'non-default': non_default_profile})
@@ -367,6 +374,9 @@ def test_statement_params_override_profile(self):
         self._verify_response_future_profile(rf, expected_profile)
 
     @mock_session_pools
+    @pytest.mark.filterwarnings("ignore:DowngradingConsistencyRetryPolicy:DeprecationWarning")
+    @pytest.mark.filterwarnings("ignore:Legacy execution parameters will be removed in 4.0:DeprecationWarning")
+    @pytest.mark.filterwarnings("ignore:Setting the consistency level at the session level will be removed in 4.0:DeprecationWarning")
     def test_no_profile_with_legacy(self):
         # don't construct with both
         self.assertRaises(ValueError, Cluster, load_balancing_policy=RoundRobinPolicy(), execution_profiles={'a': ExecutionProfile()})
@@ -393,6 +403,7 @@ def test_no_profile_with_legacy(self):
         self.assertRaises(ValueError, session.execute_async, "query", execution_profile='some name here')
 
     @mock_session_pools
+    @pytest.mark.filterwarnings("ignore:Setting the consistency level at the session level will be removed in 4.0:DeprecationWarning")
     def test_no_legacy_with_profile(self):
         cluster_init = Cluster(execution_profiles={'name': ExecutionProfile()})
         cluster_add = Cluster()
@@ -513,6 +524,7 @@ def _check_warning_on_no_lbp_with_contact_points(self, cluster_kwargs):
         self.assertIn('please specify a load-balancing policy', warning_message)
         self.assertIn("contact_points = ['127.0.0.1']", warning_message)
 
+    @pytest.mark.filterwarnings("ignore:Legacy execution parameters will be removed in 4.0:DeprecationWarning")
     def test_no_warning_on_contact_points_with_lbp_legacy_mode(self):
         """
         Test that users aren't warned when they instantiate a Cluster object

tests/unit/test_exception.py

@@ -29,7 +29,7 @@ def extract_consistency(self, msg):
         :param msg: message with consistency value
         :return: String representing consistency value
         """
-        match = re.search("'consistency':\s+'([\w\s]+)'", msg)
+        match = re.search(r"'consistency':\s+'([\w\s]+)'", msg)
         return match and match.group(1)
 
     def test_timeout_consistency(self):

tests/unit/test_metadata.py

@@ -849,9 +849,9 @@ def test_strip_frozen(self):
         argument_to_expected_results = [
             ('int', 'int'),
             ('tuple<text>', 'tuple<text>'),
-            (r'map<"!@#$%^&*()[]\ frozen >>>", int>', r'map<"!@#$%^&*()[]\ frozen >>>", int>'),  # A valid UDT name
+            (r'map<"!@#$%^&*()[]\\ frozen >>>", int>', r'map<"!@#$%^&*()[]\ frozen >>>", int>'),  # A valid UDT name
             ('frozen<tuple<text>>', 'tuple<text>'),
-            (r'frozen<map<"!@#$%^&*()[]\ frozen >>>", int>>', r'map<"!@#$%^&*()[]\ frozen >>>", int>'),
+            (r'frozen<map<"!@#$%^&*()[]\\ frozen >>>", int>>', r'map<"!@#$%^&*()[]\ frozen >>>", int>'),
             ('frozen<map<frozen<tuple<int, frozen<list<text>>, int>>, frozen<map<int, frozen<tuple<int>>>>>>',
              'map<tuple<int, list<text>, int>, map<int, tuple<int>>>'),
         ]

tests/unit/test_policies.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 import unittest
+import pytest
 
 from itertools import islice, cycle
 from mock import Mock, patch, call
@@ -1134,6 +1135,7 @@ def test_unavailable(self):
         self.assertEqual(consistency, None)
 
 
+@pytest.mark.filterwarnings("ignore:DowngradingConsistencyRetryPolicy:DeprecationWarning")
 class DowngradingConsistencyRetryPolicyTest(unittest.TestCase):
 
     def test_read_timeout(self):

tests/unit/test_response_future.py

@@ -82,7 +82,7 @@ def test_result_message(self):
 
         expected_result = (object(), object())
         rf._set_result(None, None, None, self.make_mock_response(expected_result[0], expected_result[1]))
-        result = rf.result()[0]
+        result = rf.result().one()
         self.assertEqual(result, expected_result)
 
     def test_unknown_result_class(self):
@@ -128,7 +128,7 @@ def test_other_result_message_kind(self):
         rf.send_request()
         result = Mock(spec=ResultMessage, kind=999, results=[1, 2, 3])
         rf._set_result(None, None, None, result)
-        self.assertEqual(rf.result()[0], result)
+        self.assertEqual(rf.result().one(), result)
 
     def test_heartbeat_defunct_deadlock(self):
         """
@@ -396,7 +396,7 @@ def test_first_pool_shutdown(self):
         expected_result = (object(), object())
         rf._set_result(None, None, None, self.make_mock_response(expected_result[0], expected_result[1]))
 
-        result = rf.result()[0]
+        result = rf.result().one()
         self.assertEqual(result, expected_result)
 
     def test_timeout_getting_connection_from_pool(self):
@@ -420,7 +420,7 @@ def test_timeout_getting_connection_from_pool(self):
 
         expected_result = (object(), object())
         rf._set_result(None, None, None, self.make_mock_response(expected_result[0], expected_result[1]))
-        self.assertEqual(rf.result()[0], expected_result)
+        self.assertEqual(rf.result().one(), expected_result)
 
         # make sure the exception is recorded correctly
         self.assertEqual(rf._errors, {'ip1': exc})
@@ -438,7 +438,7 @@ def test_callback(self):
 
         rf._set_result(None, None, None, self.make_mock_response(expected_result[0], expected_result[1]))
 
-        result = rf.result()[0]
+        result = rf.result().one()
         self.assertEqual(result, expected_result)
 
         callback.assert_called_once_with([expected_result], arg, **kwargs)
@@ -488,7 +488,7 @@ def test_multiple_callbacks(self):
 
         rf._set_result(None, None, None, self.make_mock_response(expected_result[0], expected_result[1]))
 
-        result = rf.result()[0]
+        result = rf.result().one()
         self.assertEqual(result, expected_result)
 
         callback.assert_called_once_with([expected_result], arg, **kwargs)
@@ -561,7 +561,7 @@ def test_add_callbacks(self):
             errback=self.assertIsInstance, errback_args=(Exception,))
 
         rf._set_result(None, None, None, self.make_mock_response(expected_result[0], expected_result[1]))
-        self.assertEqual(rf.result()[0], expected_result)
+        self.assertEqual(rf.result().one(), expected_result)
 
         callback.assert_called_once_with([expected_result], arg, **kwargs)