Skip to content

Commit e108729

Browse files
ManjotScursoragent
andcommitted
fix(replace): normalize start_scylla_service is-defined guard
Add the `is defined` guard to the replication-adjust when clauses so they match the pattern used elsewhere in the role, hardening against a future removal of the role default. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent e32cbd0 commit e108729

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

ansible-scylla-node/tasks/common.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@
426426
_keyspace_replication_strategy: "{{ system_auth_replication_strategy }}"
427427
_keyspace_rf: "{{ system_auth_rf }}"
428428
when:
429-
- start_scylla_service|bool
429+
- start_scylla_service is defined and start_scylla_service|bool
430430
- not skip_start_scylla_service|bool
431431
- adjust_system_auth_replication is defined and adjust_system_auth_replication|bool
432432
- _authentication_enabled is defined and _authentication_enabled|bool
@@ -439,7 +439,7 @@
439439
_keyspace_replication_strategy: "{{ audit_replication_strategy }}"
440440
_keyspace_rf: "{{ audit_rf }}"
441441
when:
442-
- start_scylla_service|bool
442+
- start_scylla_service is defined and start_scylla_service|bool
443443
- not skip_start_scylla_service|bool
444444
- adjust_audit_replication is defined and adjust_audit_replication|bool
445445
- _audit_enabled is defined and _audit_enabled|bool
@@ -452,7 +452,7 @@
452452
_keyspace_replication_strategy: "{{ system_distributed_replication_strategy }}"
453453
_keyspace_rf: "{{ system_distributed_rf }}"
454454
when:
455-
- start_scylla_service|bool
455+
- start_scylla_service is defined and start_scylla_service|bool
456456
- not skip_start_scylla_service|bool
457457
- adjust_system_distributed_replication is defined and adjust_system_distributed_replication|bool
458458
- system_distributed_rf is defined and system_distributed_replication_strategy is defined
@@ -464,7 +464,7 @@
464464
_keyspace_replication_strategy: "{{ system_traces_replication_strategy }}"
465465
_keyspace_rf: "{{ system_traces_rf }}"
466466
when:
467-
- start_scylla_service|bool
467+
- start_scylla_service is defined and start_scylla_service|bool
468468
- not skip_start_scylla_service|bool
469469
- adjust_system_traces_replication is defined and adjust_system_traces_replication|bool
470470
- system_traces_rf is defined and system_traces_replication_strategy is defined

0 commit comments

Comments
 (0)