improvement(treewide): Remove pylint disables

(cherry picked from commit 5c55c7c)

Author: pehala

.github/scripts/search_commits.py

@@ -24,7 +24,7 @@ def get_parser():
     return parser.parse_args()
 
 
-def main():  # pylint: disable=too-many-locals  # noqa: PLR0914
+def main():  # noqa: PLR0914
     args = get_parser()
     github = Github(github_token)
     repo = github.get_repo(args.repository, lazy=False)
@@ -44,7 +44,7 @@ def main():  # pylint: disable=too-many-locals  # noqa: PLR0914
         }
         response = requests.get(search_url, headers=headers, params=params)
         prs = response.json().get("items", [])
-        for pr in prs:  # pylint: disable=invalid-name
+        for pr in prs:
             match = re.findall(r'Parent PR: #(\d+)', pr["body"])
             if match:
                 pr_number = int(match[0])

add_new_dc_test.py

@@ -2,7 +2,7 @@
 from typing import Tuple, List
 
 from cassandra import ConsistencyLevel
-from cassandra.query import SimpleStatement  # pylint: disable=no-name-in-module
+from cassandra.query import SimpleStatement
 
 from longevity_test import LongevityTest
 from sdcm.cluster import BaseNode
@@ -19,7 +19,7 @@ class TestAddNewDc(LongevityTest):
      https://docs.scylladb.com/operating-scylla/procedures/cluster-management/add-dc-to-existing-dc/
      """
 
-    def test_add_new_dc(self) -> None:  # pylint: disable=too-many-locals
+    def test_add_new_dc(self) -> None:
 
         self.log.info("Starting add new DC test...")
         assert self.params.get('n_db_nodes').endswith(" 0"), "n_db_nodes must be a list and last dc must equal 0"

argus/client/base.py

@@ -22,7 +22,7 @@ class ArgusClient:
     schema_version: str | None = None
 
     class Routes():
-        # pylint: disable=too-few-public-methods
+        
         SUBMIT = "/testrun/$type/submit"
         GET = "/testrun/$type/$id/get"
         HEARTBEAT = "/testrun/$type/$id/heartbeat"

artifacts_test.py

@@ -46,7 +46,7 @@
 }
 
 
-class ArtifactsTest(ClusterTester):  # pylint: disable=too-many-public-methods
+class ArtifactsTest(ClusterTester):
     REPO_TABLE = "housekeeping.repo"
     CHECK_VERSION_TABLE = "housekeeping.checkversion"
 
@@ -316,7 +316,6 @@ def run_pre_create_schema(self, replication_factor=1):
                                   scylla_encryption_options=scylla_encryption_options,
                                   compaction=compaction_strategy, sstable_size=sstable_size)
 
-    # pylint: disable=too-many-statements,too-many-branches
     def test_scylla_service(self):
 
         self.run_pre_create_schema()
@@ -343,7 +342,7 @@ def test_scylla_service(self):
                     )
                 except SkipTest as exc:
                     self.log.info("Skipping IOTuneValidation due to %s", exc.args)
-                except Exception:  # pylint: disable=broad-except # noqa: BLE001
+                except Exception:  # noqa: BLE001
                     self.log.error("IOTuneValidator failed", exc_info=True)
                     TestFrameworkEvent(source={self.__class__.__name__},
                                        message="Error during IOTune params validation.",

big_cluster_test.py

@@ -13,8 +13,7 @@
 #
 # Copyright (c) 2016 ScyllaDB
 
-# TODO: this test seem to totally unused, hence disabling all pylint checks
-# pylint: disable=all
+# TODO: this test seem to totally unused
 
 import logging
 

cdc_replication_test.py

@@ -23,7 +23,7 @@
 from typing import Optional, Tuple
 
 from cassandra import ConsistencyLevel
-from cassandra.query import SimpleStatement  # pylint: disable=no-name-in-module
+from cassandra.query import SimpleStatement
 
 from sdcm import cluster
 from sdcm.tester import ClusterTester
@@ -132,7 +132,6 @@ def test_replication_longevity(self) -> None:
         self.start_replicator(Mode.DELTA)
 
         self.consistency_ok = True
-        # pylint: disable=unexpected-keyword-arg
         self.db_cluster.nemesis.append(CategoricalMonkey(
             tester_obj=self, termination_event=self.db_cluster.nemesis_termination_event,
             dist={
@@ -225,8 +224,6 @@ def test_replication_longevity(self) -> None:
             # or try to reproduce based on the logs in a smaller test.
             self.fail('Consistency check failed.')
 
-    # pylint: disable=too-many-statements,too-many-branches,too-many-locals
-
     def test_replication(self, is_gemini_test: bool, mode: Mode) -> None:
         assert is_gemini_test or (mode == Mode.DELTA), "cassandra-stress doesn't work with preimage/postimage modes"
 

cql_test.py

@@ -31,7 +31,6 @@ def test_cql_example(self):
         node = self.db_cluster.nodes[0]
         with self.db_cluster.cql_connection_patient(node) as session:
             self.create_keyspace(keyspace_name='ks', replication_factor=1)
-            # pylint: disable=no-member
             session.execute("""
                 CREATE TABLE ks.test1 (
                     k int,

destroy_data_then_repair_test.py

@@ -19,7 +19,7 @@
 
 class CorruptThenRepair(ClusterTester):
 
-    def test_destroy_data_then_repair_test_nodes(self):  # pylint: disable=invalid-name
+    def test_destroy_data_then_repair_test_nodes(self):
         # populates 100GB
         write_queue = self.populate_data_parallel(100, blocking=False)
 

docker/alternator-dns/dns_server.py

@@ -34,7 +34,7 @@ def livenodes_update():
             # If we're successful, replace livenodes by the new list
             livenodes = a
             print(livenodes)
-        except Exception:  # pylint: disable=broad-except  # noqa: BLE001
+        except Exception:  # noqa: BLE001
             # TODO: contacting this ip was unsuccessful, maybe we should
             # remove it from the list of live nodes.
             pass

functional_tests/scylla_operator/conftest.py

@@ -43,17 +43,17 @@
 # TODO: add support for multiDC setups
 
 @pytest.hookimpl(tryfirst=True, hookwrapper=True)
-def pytest_runtest_makereport(item, call):  # pylint: disable=unused-argument
+def pytest_runtest_makereport(item, call):
     # Populate test result to test function instance
     outcome = yield
     rep = outcome.get_result()
     if rep.skipped:
-        item._test_result = ('SKIPPED', rep.longrepr[2])  # pylint: disable=protected-access
-        TESTER.update_test_status(item.nodeid, *item._test_result)  # pylint: disable=protected-access
+        item._test_result = ('SKIPPED', rep.longrepr[2])
+        TESTER.update_test_status(item.nodeid, *item._test_result)
     elif rep.passed:
-        item._test_result = ('SUCCESS', None)  # pylint: disable=protected-access
+        item._test_result = ('SUCCESS', None)
     elif not rep.passed:
-        item._test_result = ('FAILED', str(rep.longrepr))  # pylint: disable=protected-access
+        item._test_result = ('FAILED', str(rep.longrepr))
 
 
 @pytest.fixture(autouse=True, name="harvest_test_results")
@@ -63,14 +63,14 @@ def fixture_harvest_test_results(request, tester: ScyllaOperatorFunctionalCluste
     def publish_test_result():
         tester.update_test_status(
             request.node.nodeid,
-            *request.node._test_result)  # pylint: disable=protected-access
+            *request.node._test_result)
 
     request.addfinalizer(publish_test_result)
 
 
 @pytest.fixture(autouse=True, scope='package', name="tester")
 def fixture_tester() -> ScyllaOperatorFunctionalClusterTester:
-    global TESTER  # pylint: disable=global-statement  # noqa: PLW0603
+    global TESTER  # noqa: PLW0603
     os.chdir(sct_abs_path())
     tester_inst = ScyllaOperatorFunctionalClusterTester()
     TESTER = tester_inst  # putting tester global, so we can report skipped test (one with mark.skip)
@@ -175,7 +175,7 @@ def _bring_cluster_back_to_original_state(
             db_cluster.restart_scylla()
         db_cluster.wait_for_nodes_up_and_normal(
             nodes=db_cluster.nodes, verification_node=db_cluster.nodes[0])
-    except Exception as exc:  # pylint: disable=broad-except  # noqa: BLE001
+    except Exception as exc:  # noqa: BLE001
         tester.healthy_flag = False
         pytest.fail("Failed to bring cluster nodes back to original state due to :\n" +
                     "".join(traceback.format_exception(type(exc), exc, exc.__traceback__)))

functional_tests/scylla_operator/libs/helpers.py

@@ -100,7 +100,7 @@ def scylla_services_names(db_cluster: ScyllaPodCluster) -> list:
             if name not in ('NAME', f"{scylla_cluster_name}-client")]
 
 
-def wait_for_resource_absence(db_cluster: ScyllaPodCluster,  # pylint: disable=too-many-arguments
+def wait_for_resource_absence(db_cluster: ScyllaPodCluster,
                               resource_type: str, resource_name: str,
                               namespace: str = SCYLLA_NAMESPACE,
                               step: int = 2, timeout: int = 60) -> None:
@@ -198,7 +198,7 @@ def verify_resharding_on_k8s(db_cluster: ScyllaPodCluster, cpus: Union[str, int,
     # One resharding with 100Gb+ may take about 3-4 minutes. So, set 5 minutes timeout per node.
     for node, liveness_probe_failures, resharding_start, resharding_finish in nodes_data:
         assert wait_for(
-            func=lambda: list(resharding_start),  # pylint: disable=cell-var-from-loop
+            func=lambda: list(resharding_start),
             step=1, timeout=600, throw_exc=False,
             text=f"Waiting for the start of resharding on the '{node.name}' node.",
         ), f"Start of resharding hasn't been detected on the '{node.name}' node."
@@ -207,7 +207,7 @@ def verify_resharding_on_k8s(db_cluster: ScyllaPodCluster, cpus: Union[str, int,
 
         # Wait for the end of resharding
         assert wait_for(
-            func=lambda: list(resharding_finish),  # pylint: disable=cell-var-from-loop
+            func=lambda: list(resharding_finish),
             step=3, timeout=600, throw_exc=False,
             text=f"Waiting for the finish of resharding on the '{node.name}' node.",
         ), f"Finish of the resharding hasn't been detected on the '{node.name}' node."

functional_tests/scylla_operator/test_functional.py

@@ -13,7 +13,6 @@
 #
 # Copyright (c) 2021 ScyllaDB
 
-#  pylint: disable=too-many-lines
 import logging
 import os
 import random
@@ -26,7 +25,7 @@
 
 import pytest
 import yaml
-from cassandra.cluster import (  # pylint: disable=no-name-in-module
+from cassandra.cluster import (
     Cluster,
     ExecutionProfile,
     EXEC_PROFILE_DEFAULT,
@@ -95,7 +94,7 @@ def test_single_operator_image_tag_is_everywhere(db_cluster):
 
 
 @pytest.mark.required_operator("v1.11.0")
-def test_deploy_quasi_multidc_db_cluster(db_cluster: ScyllaPodCluster):  # pylint: disable=too-many-locals,too-many-statements,too-many-branches  # noqa: PLR0914
+def test_deploy_quasi_multidc_db_cluster(db_cluster: ScyllaPodCluster):  # noqa: PLR0914
     """
     Deploy 2 'ScyllaCluster' K8S objects in 2 different namespaces in the single K8S cluster
     and combine them into a single DB cluster.
@@ -322,7 +321,7 @@ def wait_for_cleanup_logs(log_follower_name, log_follower, db_cluster):
                 time.sleep(4)
                 db_cluster.nodes[0].run_cqlsh(cmd=f"DROP KEYSPACE IF EXISTS {current_ks_name}", timeout=60)
                 time.sleep(4)
-            except Exception as exc:  # pylint: disable=broad-except  # noqa: BLE001
+            except Exception as exc:  # noqa: BLE001
                 # NOTE: we don't care if some of the queries fail.
                 #       At first, there are redundant ones and, at second, they are utilitary.
                 log.warning("Utilitary CQL query has failed: %s", exc)
@@ -647,7 +646,7 @@ def change_cluster_spec() -> None:
                 # NOTE: increase the value only when the sysctl spec update is successful
                 #       to avoid false negative results in further assertions
                 expected_aio_max_nr_value += 1
-            except Exception as error:  # pylint: disable=broad-except  # noqa: BLE001
+            except Exception as error:  # noqa: BLE001
                 str_error = str(error)
                 log.debug("Change /spec/sysctls value to %d failed. Error: %s",
                           expected_aio_max_nr_value, str_error)
@@ -853,7 +852,7 @@ def test_rolling_config_change_internode_compression(db_cluster, scylla_yaml):
 
 
 @pytest.mark.restart_is_used
-def test_scylla_yaml_override(db_cluster, scylla_yaml):  # pylint: disable=too-many-branches
+def test_scylla_yaml_override(db_cluster, scylla_yaml):
     """
     Test of applying scylla.yaml via configmap
     - update parameter that exists in scylla.yaml
@@ -958,7 +957,6 @@ def test_default_dns_policy(db_cluster: ScyllaPodCluster):
 @pytest.mark.required_operator("v1.8.0")
 @pytest.mark.requires_tls_and_sni
 def test_operator_managed_tls(db_cluster: ScyllaPodCluster, tmp_path: path.Path):
-    # pylint: disable=too-many-locals
 
     cluster_name = db_cluster.k8s_cluster.k8s_scylla_cluster_name
 
@@ -990,7 +988,7 @@ def test_operator_managed_tls(db_cluster: ScyllaPodCluster, tmp_path: path.Path)
     cluster = Cluster(contact_points=[db_cluster.nodes[0].cql_address], port=db_cluster.nodes[0].CQL_SSL_PORT,
                       execution_profiles={EXEC_PROFILE_DEFAULT: execution_profile})
     ssl_context = ssl.SSLContext(protocol=ssl.PROTOCOL_SSLv23)
-    ssl_context.verify_mode = ssl.VerifyMode.CERT_REQUIRED  # pylint: disable=no-member
+    ssl_context.verify_mode = ssl.VerifyMode.CERT_REQUIRED
 
     ssl_context.load_verify_locations(cadata=ca_filename.read_text())
     ssl_context.load_cert_chain(keyfile=key_filename, certfile=crt_filename)

grow_cluster_test.py

@@ -122,7 +122,7 @@ def test_grow_x_to_y(self):
         self.grow_cluster(cluster_target_size=self._cluster_target_size,
                           stress_cmd=self.get_stress_cmd())
 
-    def test_grow_3_to_4_large_partition(self):  # pylint: disable=invalid-name
+    def test_grow_3_to_4_large_partition(self):
         """
         Shorter version of the cluster growth test.
 

ics_space_amplification_goal_test.py

@@ -135,7 +135,7 @@ def _set_enforce_min_threshold_true(self):
             node.stop_scylla_server()
             node.start_scylla_server()
 
-    def test_ics_space_amplification_goal(self):  # pylint: disable=too-many-locals  # noqa: PLR0914
+    def test_ics_space_amplification_goal(self):  # noqa: PLR0914
         """
         (1) writing new data. wait for compactions to finish.
         (2) over-writing existing data.

longevity_alternator_ttl_test.py

@@ -100,7 +100,6 @@ def test_disable_enable_ttl_scan(self):
         4. Wait for TTL-scan intervals to run
         5. Run a background read stress while data is being expired.
         """
-        # pylint: disable=too-many-locals,too-many-branches,too-many-statements
 
         self.db_cluster.add_nemesis(nemesis=self.get_nemesis_class(),
                                     tester_obj=self)

longevity_large_partition_test.py

@@ -14,7 +14,6 @@ def pre_create_large_partitions_schema(self, compaction_strategy=CompactionStrat
         node = self.db_cluster.nodes[0]
         create_table_query = create_scylla_bench_table_query(compaction_strategy=compaction_strategy)
         with self.db_cluster.cql_connection_patient(node) as session:
-            # pylint: disable=no-member
             session.execute("""
                     CREATE KEYSPACE IF NOT EXISTS scylla_bench WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 3}
             """)

longevity_test.py

@@ -23,7 +23,7 @@
 
 import yaml
 from cassandra import AlreadyExists, InvalidRequest
-from cassandra.query import SimpleStatement  # pylint: disable=no-name-in-module
+from cassandra.query import SimpleStatement
 
 from sdcm import sct_abs_path
 from sdcm.sct_events.group_common_events import \
@@ -126,7 +126,6 @@ def test_custom_time(self):  # noqa: PLR0914
         """
         Run cassandra-stress with params defined in data_dir/scylla.yaml
         """
-        # pylint: disable=too-many-locals,too-many-branches,too-many-statements
 
         self.db_cluster.add_nemesis(nemesis=self.get_nemesis_class(),
                                     tester_obj=self)
@@ -206,7 +205,7 @@ def is_target_reached(current: list[int], target: list[int]) -> bool:
                 profile_dst = os.path.join('/tmp', os.path.basename(cs_profile))
                 with open(cs_profile, encoding="utf-8") as pconf:
                     cont = pconf.readlines()
-                    user_profile_table_count = self.params.get(  # pylint: disable=invalid-name
+                    user_profile_table_count = self.params.get(
                         'user_profile_table_count')
                     for _ in range(user_profile_table_count):
                         for cmd in [line.lstrip('#').strip() for line in cont if line.find('cassandra-stress') > 0]:
@@ -338,7 +337,6 @@ def _run_user_stress_in_batches(self, batch_size, stress_params_list, duration):
         :param stress_params_list: the list of all stress commands
         :return:
         """
-        # pylint: disable=too-many-locals
 
         def chunks(_list, chunk_size):
             """Yield successive n-sized chunks from _list."""
@@ -442,8 +440,7 @@ def _pre_create_schema(self, keyspace_num=1, scylla_encryption_options=None):
                               compaction=compaction_strategy, sstable_size=sstable_size)
 
     def _pre_create_templated_user_schema(self, batch_start=None, batch_end=None):
-        # pylint: disable=too-many-locals
-        user_profile_table_count = self.params.get(  # pylint: disable=invalid-name
+        user_profile_table_count = self.params.get(
             'user_profile_table_count') or 0
         cs_user_profiles = self.params.get('cs_user_profiles')
         # read user-profile
@@ -509,8 +506,7 @@ def get_email_data(self):
         })
         return email_data
 
-    def create_templated_user_stress_params(self, idx, cs_profile) -> List[Dict]:  # pylint: disable=invalid-name
-        # pylint: disable=too-many-locals
+    def create_templated_user_stress_params(self, idx, cs_profile) -> List[Dict]:
         params_list = []
         cs_duration = self.params.get('cs_duration')
 

longevity_tombstone_gc_test.py

@@ -64,7 +64,6 @@ def test_switch_tombstone_gc_modes(self):
         Run a major compaction.
         Verify no tombstones.
         """
-        # pylint: disable=too-many-locals,too-many-statements
 
         self.create_tables_for_scylla_bench()
         self.db_node = self.db_cluster.nodes[0]