Skip to content

Commit 8dcdcc9

Browse files
committed
fix(NodeBase): add missing _set_keep_duration implemetions
b8b20a2 introducde changes in as baseclass that didn't included implemetions in all it's users. that can break the EKS/GKE flows (and pylint was yelling at it in backports to old branches)
1 parent 582f632 commit 8dcdcc9

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

sdcm/cluster_azure.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ def _set_keep_alive(self) -> bool:
9393
return super()._set_keep_alive()
9494

9595
@retrying(n=6, sleep_time=1)
96-
def _set_keep_duration(self, duration: int) -> None:
97-
self._instance.add_tags({"keep": str(duration)})
96+
def _set_keep_duration(self, duration_in_minutes: int) -> None:
97+
self._instance.add_tags({"keep": str(duration_in_minutes)})
9898

9999
def _refresh_instance_state(self):
100100
ip_tuple = ([self._instance.public_ip_address], [self._instance.private_ip_address])

sdcm/cluster_k8s/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,6 +1796,9 @@ def _init_remoter(self, ssh_login_info):
17961796
def _init_port_mapping(self):
17971797
pass
17981798

1799+
def _set_keep_duration(self, duration_in_minutes: int):
1800+
pass
1801+
17991802
@property
18001803
def system_log(self):
18011804
return os.path.join(self.logdir, "system.log")

unit_tests/dummy_remote.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ def _get_ipv6_ip_address(self):
8080
def check_spot_termination(self):
8181
pass
8282

83+
def _set_keep_duration(self, duration_in_minutes: int) -> None:
84+
pass
85+
8386
def restart(self):
8487
pass
8588

0 commit comments

Comments
 (0)