fix(nemesis): another place of cm

Author: aleksbykov

sdcm/nemesis.py

@@ -5520,13 +5520,14 @@ def drop_keyspace(node):
 
         simulate_node_unavailability = node_operations.block_scylla_ports if use_iptables else node_operations.pause_scylla_with_sigstop
         with (self.run_nemesis(node_list=self.cluster.nodes, nemesis_label=f"Running {simulate_node_unavailability.__name__}") as working_node,
-                node_operations.block_loaders_payload_from_scylla_node(self.target_node, self.loaders.nodes),
               ExitStack() as stack):
+
             stack.callback(drop_keyspace, node=working_node)
             target_host_id = self.target_node.host_id
             stack.callback(self._remove_node_add_node, verification_node=working_node, node_to_remove=self.target_node,
                            remove_node_host_id=target_host_id)
-
+            stack.enter_context(node_operations.block_loaders_payload_for_scylla_node(
+                self.target_node, loader_nodes=self.loaders.nodes))
             self.tester.create_keyspace(keyspace_name, replication_factor=3)
             self.tester.create_table(name=table_name, keyspace_name=keyspace_name, key_type="bigint",
                                      columns={"name": "text"})

sdcm/utils/nemesis_utils/node_operations.py

@@ -39,7 +39,7 @@ def pause_scylla_with_sigstop(target_node: BaseNode):
 
 
 @contextlib.contextmanager
-def block_loaders_payload_from_scylla_node(scylla_node: BaseNode, loader_nodes: list[BaseNode]):
+def block_loaders_payload_for_scylla_node(scylla_node: BaseNode, loader_nodes: list[BaseNode]):
     ports = [9042, 9142, 19042, 19142]
     scylla_node.install_package("iptables")
     scylla_node.start_service("iptables", ignore_status=True)
@@ -52,13 +52,14 @@ def block_loaders_payload_from_scylla_node(scylla_node: BaseNode, loader_nodes:
         scylla_node.remoter.sudo(
             f"ip6tables -A INPUT -s {','.join(blocking_ips)} -p tcp --dport {port} -j DROP", ignore_status=True)
     yield
-    scylla_node.log.debug("Remove all iptable rules %s", scylla_node.name)
-    for port in ports:
-        scylla_node.remoter.sudo(
-            f"iptables -D INPUT -s {','.join(blocking_ips)} -p tcp --dport {port} -j DROP", ignore_status=True)
-        scylla_node.remoter.sudo(
-            f"ip6tables -D INPUT -s {','.join(blocking_ips)} -p tcp --dport {port} -j DROP", ignore_status=True)
-    scylla_node.stop_service("iptables", ignore_status=True)
+    # if scylla_node is alive, then delete the iptables rules
+    if scylla_node.remoter.is_up():
+        for port in ports:
+            scylla_node.remoter.sudo(
+                f"iptables -D INPUT -s {','.join(blocking_ips)} -p tcp --dport {port} -j DROP", ignore_status=True)
+            scylla_node.remoter.sudo(
+                f"ip6tables -D INPUT -s {','.join(blocking_ips)} -p tcp --dport {port} -j DROP", ignore_status=True)
+        scylla_node.stop_service("iptables", ignore_status=True)
 
 
 def is_node_removed_from_cluster(removed_node: BaseNode, verification_node: BaseNode) -> bool: