Skip to content

Commit aad9ac8

Browse files
pehalavponomaryov
authored andcommitted
improvement(test_nemesis): Parametrize test_is_it_on_kubernetes
(cherry picked from commit 40d435b)
1 parent 7008dba commit aad9ac8

File tree

1 file changed

+16
-36
lines changed

1 file changed

+16
-36
lines changed

unit_tests/test_nemesis.py

Lines changed: 16 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -140,47 +140,27 @@ def test_list_nemesis_of_added_disrupt_methods(capsys):
140140
assert "It Works!" in captured.out
141141

142142

143-
def test_is_it_on_kubernetes():
144-
class FakeLocalMinimalScyllaPodCluster(LocalMinimalScyllaPodCluster):
145-
def __init__(self, params: dict = None):
146-
self.params = params
147-
self.nodes = []
148-
149-
class FakeGkeScyllaPodCluster(GkeScyllaPodCluster):
150-
def __init__(self, params: dict = None):
151-
self.params = params
152-
self.nodes = []
153-
154-
class FakeEksScyllaPodCluster(EksScyllaPodCluster):
155-
def __init__(self, params: dict = None):
156-
self.params = params
157-
self.nodes = []
158-
159-
class FakeScyllaGCECluster(ScyllaGCECluster):
160-
def __init__(self, params: dict = None):
161-
self.params = params
162-
self.nodes = []
163-
164-
class FakeScyllaAWSCluster(ScyllaAWSCluster):
165-
def __init__(self, params: dict = None):
166-
self.params = params
167-
self.nodes = []
168-
169-
class FakeScyllaDockerCluster(ScyllaDockerCluster):
143+
@pytest.mark.parametrize(
144+
"parent, result",
145+
[
146+
(LocalMinimalScyllaPodCluster, True),
147+
(GkeScyllaPodCluster, True),
148+
(EksScyllaPodCluster, True),
149+
(ScyllaGCECluster, False),
150+
(ScyllaAWSCluster, False),
151+
(ScyllaDockerCluster, False)
152+
]
153+
)
154+
def test_is_it_on_kubernetes(parent, result):
155+
class FakeClass(parent):
170156
def __init__(self, params: dict = None):
171157
self.params = params
172158
self.nodes = []
173159

174160
params = {'nemesis_interval': 10, 'nemesis_filter_seeds': 1}
175-
176-
assert FakeNemesis(FakeTester(db_cluster=FakeLocalMinimalScyllaPodCluster(),
177-
params=params), None)._is_it_on_kubernetes()
178-
assert FakeNemesis(FakeTester(db_cluster=FakeGkeScyllaPodCluster(), params=params), None)._is_it_on_kubernetes()
179-
assert FakeNemesis(FakeTester(db_cluster=FakeEksScyllaPodCluster(), params=params), None)._is_it_on_kubernetes()
180-
181-
assert not FakeNemesis(FakeTester(db_cluster=FakeScyllaGCECluster(), params=params), None)._is_it_on_kubernetes()
182-
assert not FakeNemesis(FakeTester(db_cluster=FakeScyllaAWSCluster(), params=params), None)._is_it_on_kubernetes()
183-
assert not FakeNemesis(FakeTester(db_cluster=FakeScyllaDockerCluster(), params=params), None)._is_it_on_kubernetes()
161+
nemesis = FakeNemesis(FakeTester(db_cluster=FakeClass(),
162+
params=params), None)
163+
assert nemesis._is_it_on_kubernetes() == result
184164

185165

186166
def test_categorical_monkey():

0 commit comments

Comments
 (0)