fix(enable_default_filters): move DB event filter for raft error to default filters

PR scylladb/scylla-cluster-tests/#10386 filter some expected
raft error messages globally. But this change broke integration
unit test. Issue #10676.

Move DB event Filter from `ignore_topology_change_coordinator_errors`
context manager to `enable_default_filters`. If the event will be
filtered globally, then no need to filter it with cm.

Fixes #10676

(cherry picked from commit 987afc1)

Author: aleksbykov

sdcm/sct_events/group_common_events.py

@@ -98,12 +98,6 @@ def ignore_topology_change_coordinator_errors():
                 line=r".*raft_topology - topology change coordinator fiber got error exceptions::unavailable_exception "
                      r"\(Cannot achieve consistency level for cl ALL\.",
             ))
-            stack.enter_context(DbEventsFilter(
-                db_event=DatabaseLogEvent.RUNTIME_ERROR,
-                line=r".*raft_topology - topology change coordinator fiber got error std::runtime_error"
-                     r" \(raft topology: exec_global_command\(barrier\) failed with seastar::rpc::closed_erro"
-                     r"r \(connection is closed\)\)"
-            ))
             stack.enter_context(DbEventsFilter(
                 db_event=DatabaseLogEvent.RUNTIME_ERROR,
                 line=r".*raft_topology - drain rpc failed, proceed to fence old writes:.*connection is closed",

sdcm/sct_events/setup.py

@@ -34,7 +34,6 @@
     EVENTS_GRAFANA_ANNOTATOR_ID, EVENTS_GRAFANA_AGGREGATOR_ID, EVENTS_GRAFANA_POSTMAN_ID, \
     EventsProcessesRegistry, create_default_events_process_registry, get_events_process, EVENTS_HANDLER_ID, EVENTS_COUNTER_ID
 from sdcm.utils.issues import SkipPerIssues
-from sdcm.sct_events.group_common_events import ignore_topology_change_coordinator_errors
 
 
 EVENTS_DEVICE_START_DELAY = 1  # seconds
@@ -157,7 +156,10 @@ def enable_default_filters(sct_config: SCTConfiguration):  # pylint: disable=unu
     # upgrades and any place where the race between raft global barrier and gossipier could
     # take place. So ignore such messages globally for any sct test.
     # TODO: this should be removed after gossiper will be removed.
-    ignore_topology_change_coordinator_errors().__enter__()
+    DbEventsFilter(db_event=DatabaseLogEvent.RUNTIME_ERROR,
+                   line=r".*raft_topology - topology change coordinator fiber got error std::runtime_error"
+                        r" \(raft topology: exec_global_command\(barrier\) failed with seastar::rpc::closed_error"
+                        r" \(connection is closed\)\)").publish()
 
 
 __all__ = ("start_events_device", "stop_events_device", "enable_default_filters")

unit_tests/test_events.py

@@ -412,7 +412,7 @@ def test_default_filters(self):
         with environment(SCT_CLUSTER_BACKEND='docker'):
             enable_default_filters(SCTConfiguration())
 
-        with self.wait_for_n_events(self.get_events_logger(), count=4):
+        with self.wait_for_n_events(self.get_events_logger(), count=5):
             DatabaseLogEvent.BACKTRACE() \
                 .add_info(node="A",
                           line_number=22,
@@ -439,6 +439,13 @@ def test_default_filters(self):
                      ".c.sct-project-1.internal/10.142.1.155:9042: Cannot achieve consistency level for cl ONE. Requires 1, alive 0",
             ).publish()
 
+            DatabaseLogEvent.RUNTIME_ERROR().add_info(
+                node="A",
+                line_number=22,
+                line="ERROR 2023-12-18 12:45:25,673 [shard 0: gms] raft_topology - topology change coordinator fiber got error std::runtime_error "
+                     "(raft topology: exec_global_command(barrier) failed with seastar::rpc::closed_error (connection is closed))"
+            ).publish()
+
         log_content = self.get_event_log_file("events.log")
 
         self.assertIn("other back trace", log_content)
@@ -451,6 +458,7 @@ def test_default_filters(self):
         error_log_content = self.get_event_log_file("error.log")
         assert 'data_dictionary::no_such_column_family' not in error_log_content
         assert 'Authentication error' in error_log_content
+        assert 'topology change coordinator fiber got error' not in error_log_content
 
     def test_failed_stall_during_filter(self):
         with self.wait_for_n_events(self.get_events_logger(), count=5, timeout=3):